Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12888] Fix --no-exclude-limit for cops with Max config option #12902

Merged
merged 1 commit into from
May 16, 2024

Conversation

Earlopain
Copy link
Contributor

Fixes #12888. Basically, the problem here was a missing no_exclude_limit? when deciding if Max should be set. Factored out into its own method because of Metrics cops.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit 065fb23 into rubocop:master May 16, 2024
33 checks passed
@koic
Copy link
Member

koic commented May 16, 2024

Thanks!

@Earlopain Earlopain deleted the max-with-no-exclude-limit branch May 16, 2024 05:20
mjankowski added a commit to mjankowski/mastodon that referenced this pull request May 26, 2024
Includes changes from latest version: rubocop/rubocop#12902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics/AbcSize with auto-gen-only-exclude option
2 participants