Allow unknown types in OPML > 1.x, per:

http://scripting.com/stories/2010/06/15/aBugInTheOpmlValidator.html
rubys · Jun 16, 2010 · 3be35d3 · 3be35d3
1 parent 0912c63
commit 3be35d3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/feedvalidator/opml.py b/src/feedvalidator/opml.py
@@ -132,7 +132,12 @@ def validate(self):
 
       else:
 
-        self.log(InvalidOutlineType({"parent":self.parent.name, "element":self.name, "value":self.attrs[(None,'type')]}))
+        opml = self.parent
+        while opml and opml.name != 'opml':
+            opml = opml.parent
+
+        if opml and opml.attrs.get((None,'version')).startswith('1.'):
+            self.log(InvalidOutlineType({"parent":self.parent.name, "element":self.name, "value":self.attrs[(None,'type')]}))
 
     if (None,'version') in self.attrs.getNames():
       if self.attrs[(None,'version')] not in opmlOutline.versionList:

diff --git a/testcases/opml/clean/unknownOutlineType2.opml b/testcases/opml/clean/unknownOutlineType2.opml
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="ISO-8859-1"?>
+
+<!--
+  Description:  Unknown outline type
+  Expect:       !InvalidOutlineType
+-->
+
+<opml version="2.0">
+	<head>
+		<title>Unknown outline type</title>
+		</head>
+	<body>
+		<outline text="Who's heard of this type?" type="oy-vey"/>
+		</body>
+	</opml>