Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not emit syntactic attributes in semantic KORE output #4134

Closed
tothtamas28 opened this issue Mar 26, 2024 · 0 comments · Fixed by #4146
Closed

Do not emit syntactic attributes in semantic KORE output #4134

tothtamas28 opened this issue Mar 26, 2024 · 0 comments · Fixed by #4146
Assignees
@tothtamas28
Labels
attributes

Comments

@tothtamas28
Copy link
Contributor

tothtamas28 commented Mar 26, 2024 •
edited

Related:

There are certain symbol attributes in definition.kore that are only used for unparsing KORE patterns:

  • assoc
  • bracket
  • colors
  • comm
  • format
  • left
  • priorities
  • right
  • terminals

These attributes should only be generated in syntaxDefinition.kore.
This was referenced Mar 28, 2024
Merged
Merged
@tothtamas28 tothtamas28 linked a pull request Mar 28, 2024 that will close this issue
Only generate syntactic attributes for syntaxDefinition.kore #4146
Merged
rv-jenkins pushed a commit that referenced this issue Apr 2, 2024
@tothtamas28
Refactor addKoreAttributes (#4145)
953b0b9 
Preparatory refactoring for:
* #4134

Changes:
* Extract method `semanticAttributes`
* Extract method `syntaxAttributes`
* Several small changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tothtamas28 tothtamas28

Labels
attributes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only generate syntactic attributes for syntaxDefinition.kore runtimeverification/k
1 participant
@tothtamas28