Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor addKoreAttributes #4145

Merged
merged 14 commits into from Apr 2, 2024
Merged

Refactor addKoreAttributes #4145

merged 14 commits into from Apr 2, 2024

Conversation

tothtamas28
Copy link
Contributor

@tothtamas28 tothtamas28 commented Mar 28, 2024 •
edited

Preparatory refactoring for:

Changes:

  • Extract method semanticAttributes
  • Extract method syntaxAttributes
  • Several small changes

@tothtamas28 tothtamas28 self-assigned this Mar 28, 2024
@tothtamas28 tothtamas28 marked this pull request as ready for review March 28, 2024 14:36
gtrepta
gtrepta approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@gtrepta gtrepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rv-jenkins rv-jenkins merged commit 953b0b9 into develop Apr 2, 2024
8 checks passed
@rv-jenkins rv-jenkins deleted the refactor-kore-attributes branch April 2, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtrepta gtrepta gtrepta approved these changes

@Baltoli Baltoli Awaiting requested review from Baltoli

@Scott-Guest Scott-Guest Awaiting requested review from Scott-Guest

Assignees

@tothtamas28 tothtamas28

Labels
attributes automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tothtamas28 @gtrepta @rv-jenkins