Port TopologicalSort to Java
#4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scott-Guest
commented
Mar 19, 2024
| @@ -19,7 +19,6 @@ object Collections { | |||
| def immutable[T](s: java.util.Set[T]): Set[T] = s.asScala.toSet | |||
| def immutable[T](s: java.util.List[T]): Seq[T] = s.asScala | |||
| def immutable[K, V](s: java.util.Map[K, V]): Map[K, V] = s.asScala | |||
| def immutable[T](s: Array[T]): Seq[T] = s | |||
There was a problem hiding this comment.
Removed this because it overlaps with the immutable[T](s: java.util.List[T]): Seq[T] overload, making the latter unusable (and it's dead code anyways).
Baltoli
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4030
Ports the
TopologicalSortclass to Java.Once again, this is a direct translation, replacing functional idioms with either direct iteration or equivalent
Streamfunctions. The only semantic change is returning anOptionalrather than reporting an error when there's a cycle.