New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usages of K error handling infrastructure #1001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
reviewed
Mar 1, 2024
matching/src/main/java/org/kframework/backend/llvm/matching/MatchingException.java
Outdated
Show resolved
Hide resolved
matching/src/main/java/org/kframework/backend/llvm/matching/MatchingException.java
Outdated
Show resolved
Hide resolved
matching/src/main/java/org/kframework/backend/llvm/matching/MatchingExceptionType.java
Outdated
Show resolved
Hide resolved
…tchingException.java Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
…ion/llvm-backend into remove-k-errors
tothtamas28
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #999
We are currently working on removing the reverse dependency that the LLVM backend has on the K frontend's data structures; this PR takes a first step towards that goal by removing the backend's use of the K exception infrastructure for throwing errors.
The K infrastructure is replaced with a simple exception class that the frontend will be able to catch and reinterpret as appropriate.
This PR needs a matching change to the K frontend to work, along with appropriate lockstep merging.