Skip to content

Commit

Permalink
Update attributes.rs
Browse files Browse the repository at this point in the history
Some comment refinements inspired by review feedback.
  • Loading branch information
pnkfelix committed Oct 3, 2019
1 parent e7e6dec commit 5e7e8cd
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/librustc_codegen_llvm/attributes.rs
Expand Up @@ -281,7 +281,7 @@ pub fn from_fn_attrs(
//
// However, in the long term we should either:
// - fold this into final else (i.e. stop inspecting `id`)
// - adopt Rust PR #63909.
// - or, adopt Rust PR #63909.
//
// see also Rust RFC 2753.

Expand All @@ -302,9 +302,10 @@ pub fn from_fn_attrs(
// UB otherwise. (At least for now; see also
// rust-lang/rust#63909 and Rust RFC 2753.)
//
// Items defined in Rust with non-Rust ABIs (case 2) are
// defined to not unwind. We insert shims to abort if an
// unwind happens to enforce this.
// Items defined in Rust with non-Rust ABIs (case 2) are also
// not supposed to unwind. Whether this should be enforced
// (versus stating it is UB) and *how* it would be enforced
// is currently under discussion; see rust-lang/rust#58794.
//
// In either case, we mark item as explicitly nounwind.
false
Expand Down

0 comments on commit 5e7e8cd

Please sign in to comment.