Skip to content

Commit

Permalink
Update ring_buf.rs from fallout of #18827.
Browse files Browse the repository at this point in the history
  • Loading branch information
csherratt committed Nov 15, 2014
1 parent 4019118 commit 6277e3b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/libcollections/ring_buf.rs
Expand Up @@ -22,7 +22,7 @@ use core::raw::Slice as RawSlice;
use core::ptr;
use core::kinds::marker;
use core::mem;
use core::num;
use core::num::{Int, UnsignedInt};

use std::hash::{Writer, Hash};
use std::cmp;
Expand Down Expand Up @@ -115,8 +115,8 @@ impl<T> RingBuf<T> {
#[unstable = "matches collection reform specification, waiting for dust to settle"]
pub fn with_capacity(n: uint) -> RingBuf<T> {
// +1 since the ringbuffer always leaves one space empty
let cap = num::next_power_of_two(cmp::max(n + 1, MINIMUM_CAPACITY));
let size = cap.checked_mul(&mem::size_of::<T>())
let cap = cmp::max(n + 1, MINIMUM_CAPACITY).next_power_of_two();
let size = cap.checked_mul(mem::size_of::<T>())
.expect("capacity overflow");

let ptr = if mem::size_of::<T>() != 0 {
Expand Down Expand Up @@ -280,12 +280,12 @@ impl<T> RingBuf<T> {
let new_len = self.len() + additional;
assert!(new_len + 1 > self.len(), "capacity overflow");
if new_len > self.capacity() {
let count = num::next_power_of_two(new_len + 1);
let count = (new_len + 1).next_power_of_two();
assert!(count >= new_len + 1);

if mem::size_of::<T>() != 0 {
let old = self.cap * mem::size_of::<T>();
let new = count.checked_mul(&mem::size_of::<T>())
let new = count.checked_mul(mem::size_of::<T>())
.expect("capacity overflow");
unsafe {
self.ptr = heap::reallocate(self.ptr as *mut u8,
Expand Down

17 comments on commit 6277e3b

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from huonw
at csherratt@6277e3b

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging csherratt/rust/ringbuf-remove-option = 6277e3b into auto

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csherratt/rust/ringbuf-remove-option = 6277e3b merged ok, testing candidate = f80c58ef

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from huonw
at csherratt@6277e3b

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging csherratt/rust/ringbuf-remove-option = 6277e3b into auto

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csherratt/rust/ringbuf-remove-option = 6277e3b merged ok, testing candidate = dff771ca

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from huonw
at csherratt@6277e3b

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging csherratt/rust/ringbuf-remove-option = 6277e3b into auto

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csherratt/rust/ringbuf-remove-option = 6277e3b merged ok, testing candidate = 116cf62c

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from huonw
at csherratt@6277e3b

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging csherratt/rust/ringbuf-remove-option = 6277e3b into auto

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

csherratt/rust/ringbuf-remove-option = 6277e3b merged ok, testing candidate = 0b7b4f0

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 6277e3b Nov 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 0b7b4f0

Please sign in to comment.