auto merge of #8441 : erickt/rust/deny-warnings, r=erickt

This patch makes sure that code is warning-free for all of the rust libraries.
rust-lang · Aug 17, 2013 · 7503396 · 7503396
2 parents 29a67d1 + cc56708
commit 7503396
Show file tree

Hide file tree

Showing 405 changed files with 709 additions and 590 deletions.
diff --git a/mk/target.mk b/mk/target.mk
@@ -69,7 +69,7 @@ $$(TLIB$(1)_T_$(2)_H_$(3))/$(CFG_LIBSYNTAX_$(3)): \
 		| $$(TLIB$(1)_T_$(2)_H_$(3))/
 	@$$(call E, compile_and_link: $$@)
 	$$(call REMOVE_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBSYNTAX_GLOB_$(2)),$$(notdir $$@))
-	$$(STAGE$(1)_T_$(2)_H_$(3)) $(BORROWCK) --out-dir $$(@D) $$< && touch $$@
+	$$(STAGE$(1)_T_$(2)_H_$(3)) $$(WFLAGS_ST$(1)) $(BORROWCK) --out-dir $$(@D) $$< && touch $$@
 	$$(call LIST_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBSYNTAX_GLOB_$(2)),$$(notdir $$@))
 
 # Only build the compiler for host triples
@@ -90,7 +90,7 @@ $$(TLIB$(1)_T_$(2)_H_$(3))/$(CFG_LIBRUSTC_$(3)):		\
 		| $$(TLIB$(1)_T_$(2)_H_$(3))/
 	@$$(call E, compile_and_link: $$@)
 	$$(call REMOVE_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBRUSTC_GLOB_$(2)),$$(notdir $$@))
-	$$(STAGE$(1)_T_$(2)_H_$(3)) --out-dir $$(@D) $$< && touch $$@
+	$$(STAGE$(1)_T_$(2)_H_$(3)) $$(WFLAGS_ST$(1)) --out-dir $$(@D) $$< && touch $$@
 	$$(call LIST_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBRUSTC_GLOB_$(2)),$$(notdir $$@))
 
 $$(TBIN$(1)_T_$(2)_H_$(3))/rustc$$(X_$(3)):			\

diff --git a/mk/tools.mk b/mk/tools.mk
@@ -67,7 +67,7 @@ $$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_LIBRUSTDOC_$(4)):		\
 		| $$(TLIB$(1)_T_$(4)_H_$(3))/
 	@$$(call E, compile_and_link: $$@)
 	$$(call REMOVE_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBRUSTDOC_GLOB_$(4)),$$(notdir $$@))
-	$$(STAGE$(1)_T_$(4)_H_$(3)) --out-dir $$(@D) $$< && touch $$@
+	$$(STAGE$(1)_T_$(4)_H_$(3)) $$(WFLAGS_ST$(1)) --out-dir $$(@D) $$< && touch $$@
 	$$(call LIST_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBRUSTDOC_GLOB_$(4)),$$(notdir $$@))
 
 $$(TBIN$(1)_T_$(4)_H_$(3))/rustdoc$$(X_$(4)):			\
@@ -85,7 +85,7 @@ $$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_LIBRUSTI_$(4)):		\
 		| $$(TLIB$(1)_T_$(4)_H_$(3))/
 	@$$(call E, compile_and_link: $$@)
 	$$(call REMOVE_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBRUSTI_GLOB_$(4)),$$(notdir $$@))
-	$$(STAGE$(1)_T_$(4)_H_$(3)) --out-dir $$(@D) $$< && touch $$@
+	$$(STAGE$(1)_T_$(4)_H_$(3)) $$(WFLAGS_ST$(1)) --out-dir $$(@D) $$< && touch $$@
 	$$(call LIST_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBRUSTI_GLOB_$(4)),$$(notdir $$@))
 
 $$(TBIN$(1)_T_$(4)_H_$(3))/rusti$$(X_$(4)):			\
@@ -106,7 +106,7 @@ $$(TLIB$(1)_T_$(4)_H_$(3))/$(CFG_LIBRUST_$(4)):		\
 		| $$(TLIB$(1)_T_$(4)_H_$(3))/
 	@$$(call E, compile_and_link: $$@)
 	$$(call REMOVE_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBRUST_GLOB_$(4)),$$(notdir $$@))
-	$$(STAGE$(1)_T_$(4)_H_$(3)) --out-dir $$(@D) $$< && touch $$@
+	$$(STAGE$(1)_T_$(4)_H_$(3)) $$(WFLAGS_ST$(1)) --out-dir $$(@D) $$< && touch $$@
 	$$(call LIST_ALL_OLD_GLOB_MATCHES_EXCEPT,$$(dir $$@),$(LIBRUST_GLOB_$(4)),$$(notdir $$@))
 
 $$(TBIN$(1)_T_$(4)_H_$(3))/rust$$(X_$(4)):			\

diff --git a/src/librustc/middle/lint.rs b/src/librustc/middle/lint.rs
@@ -480,7 +480,7 @@ impl Context {
                             (orig.visit_item)(it, (self, stopping));
                         }
                         NewVisitor(new_visitor) => {
-                            let mut new_visitor = new_visitor;
+                            let new_visitor = new_visitor;
                             new_visitor.visit_item(it, ());
                         }
                     }
@@ -520,7 +520,7 @@ impl Context {
                             let fk = visit::fk_method(m.ident,
                                                       &m.generics,
                                                       m);
-                            let mut new_visitor = new_visitor;
+                            let new_visitor = new_visitor;
                             new_visitor.visit_fn(&fk,
                                                  &m.decl,
                                                  &m.body,

diff --git a/src/libstd/ptr.rs b/src/libstd/ptr.rs
@@ -648,7 +648,7 @@ pub mod ptr_tests {
                 one, two, three
             ];
 
-            do arr.as_imm_buf |arr_ptr, arr_len| {
+            do arr.as_imm_buf |arr_ptr, _| {
                 let mut ctr = 0;
                 let mut iteration_count = 0;
                 do array_each(arr_ptr) |e| {

diff --git a/src/libsyntax/parse/attr.rs b/src/libsyntax/parse/attr.rs
@@ -10,7 +10,6 @@
 
 use ast;
 use codemap::{spanned, mk_sp};
-use codemap::BytePos;
 use parse::common::*; //resolve bug?
 use parse::token;
 use parse::parser::Parser;

diff --git a/src/test/auxiliary/cci_capture_clause.rs b/src/test/auxiliary/cci_capture_clause.rs
@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use std::comm::*;
 use std::task;
 
 pub fn foo<T:Send + Clone>(x: T) -> Port<T> {

diff --git a/src/test/auxiliary/cci_class_5.rs b/src/test/auxiliary/cci_class_5.rs
@@ -9,8 +9,6 @@
 // except according to those terms.
 
 pub mod kitties {
-    use std::uint;
-
     pub struct cat {
         priv meows : uint,
         how_hungry : int,
@@ -26,5 +24,4 @@ pub mod kitties {
             how_hungry: in_y
         }
     }
-
 }
diff --git a/src/test/auxiliary/cci_class_cast.rs b/src/test/auxiliary/cci_class_cast.rs
@@ -8,8 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use std::to_str::*;
-
 pub mod kitty {
     pub struct cat {
       priv meows : uint,

diff --git a/src/test/auxiliary/crate-method-reexport-grrrrrrr2.rs b/src/test/auxiliary/crate-method-reexport-grrrrrrr2.rs
@@ -20,7 +20,7 @@ pub mod name_pool {
     }
 
     impl add for name_pool {
-        fn add(&self, s: ~str) {
+        fn add(&self, _s: ~str) {
         }
     }
 }

diff --git a/src/test/auxiliary/crateresolve5-1.rs b/src/test/auxiliary/crateresolve5-1.rs
@@ -25,7 +25,7 @@ pub enum e {
 
 pub fn nominal() -> e { e_val }
 
-pub fn nominal_eq(e1: e, e2: e) -> bool { true }
+pub fn nominal_eq(_e1: e, _e2: e) -> bool { true }
 
 impl Eq for e {
     fn eq(&self, other: &e) -> bool { nominal_eq(*self, *other) }

diff --git a/src/test/auxiliary/crateresolve5-2.rs b/src/test/auxiliary/crateresolve5-2.rs
@@ -29,6 +29,6 @@ impl Eq for e {
 
 pub fn nominal() -> e { e_val }
 
-pub fn nominal_neq(e1: e, e2: e) -> bool { false }
+pub fn nominal_neq(_e1: e, _e2: e) -> bool { false }
 
 pub fn f() -> int { 20 }
diff --git a/src/test/auxiliary/issue-2526.rs b/src/test/auxiliary/issue-2526.rs
@@ -35,9 +35,7 @@ fn arc<T:Freeze>(_data: T) -> arc_destruct<T> {
 }
 
 fn init() -> arc_destruct<context_res> {
-    unsafe {
-        arc(context_res())
-    }
+    arc(context_res())
 }
 
 struct context_res {

diff --git a/src/test/auxiliary/issue2378a.rs b/src/test/auxiliary/issue2378a.rs
@@ -14,7 +14,7 @@
 enum maybe<T> { just(T), nothing }
 
 impl <T:Clone> Index<uint,T> for maybe<T> {
-    fn index(&self, idx: &uint) -> T {
+    fn index(&self, _idx: &uint) -> T {
         match self {
             &just(ref t) => (*t).clone(),
             &nothing => { fail!(); }

diff --git a/src/test/auxiliary/issue_2316_b.rs b/src/test/auxiliary/issue_2316_b.rs
@@ -8,6 +8,8 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
+#[allow(unused_imports)];
+
 extern mod issue_2316_a;
 
 pub mod cloth {

diff --git a/src/test/auxiliary/moves_based_on_type_lib.rs b/src/test/auxiliary/moves_based_on_type_lib.rs
@@ -23,5 +23,5 @@ impl Drop for S {
 pub fn f() {
     let x = S { x: 1 };
     let y = x;
-    let z = y;
+    let _z = y;
 }
diff --git a/src/test/auxiliary/trait_default_method_xc_aux.rs b/src/test/auxiliary/trait_default_method_xc_aux.rs
@@ -19,7 +19,7 @@ impl A for Something {
 
 trait B<T> {
     fn thing<U>(&self, x: T, y: U) -> (T, U) { (x, y) }
-    fn staticthing<U>(z: &Self, x: T, y: U) -> (T, U) { (x, y) }
+    fn staticthing<U>(_z: &Self, x: T, y: U) -> (T, U) { (x, y) }
 }
 
 impl<T> B<T> for int { }

diff --git a/src/test/bench/core-std.rs b/src/test/bench/core-std.rs
@@ -13,14 +13,11 @@
 extern mod extra;
 
 use extra::time::precise_time_s;
-use std::int;
 use std::io;
 use std::os;
 use std::rand::RngUtil;
 use std::rand;
-use std::result;
 use std::str;
-use std::uint;
 use std::util;
 use std::vec;
 

diff --git a/src/test/bench/msgsend-ring-mutex-arcs.rs b/src/test/bench/msgsend-ring-mutex-arcs.rs
@@ -21,7 +21,6 @@ use extra::arc;
 use extra::future;
 use extra::time;
 use std::cell::Cell;
-use std::io;
 use std::os;
 use std::uint;
 

diff --git a/src/test/bench/msgsend-ring-rw-arcs.rs b/src/test/bench/msgsend-ring-rw-arcs.rs
@@ -21,7 +21,6 @@ use extra::arc;
 use extra::future;
 use extra::time;
 use std::cell::Cell;
-use std::io;
 use std::os;
 use std::uint;
 

diff --git a/src/test/bench/noise.rs b/src/test/bench/noise.rs
@@ -1,7 +1,6 @@
 // Perlin noise benchmark from https://gist.github.com/1170424
 
 use std::float;
-use std::int;
 use std::rand::{Rng, RngUtil};
 use std::rand;
 

diff --git a/src/test/bench/rt-messaging-ping-pong.rs b/src/test/bench/rt-messaging-ping-pong.rs
@@ -10,7 +10,6 @@
 
 extern mod extra;
 
-use std::task::spawn;
 use std::os;
 use std::uint;
 use std::rt::test::spawntask_later;

diff --git a/src/test/bench/rt-parfib.rs b/src/test/bench/rt-parfib.rs
@@ -10,7 +10,6 @@
 
 extern mod extra;
 
-use std::task::spawn;
 use std::os;
 use std::uint;
 use std::rt::test::spawntask_later;

diff --git a/src/test/bench/shootout-ackermann.rs b/src/test/bench/shootout-ackermann.rs
@@ -11,7 +11,6 @@
 extern mod extra;
 
 use std::int;
-use std::io;
 use std::os;
 
 fn ack(m: int, n: int) -> int {

diff --git a/src/test/bench/shootout-fasta.rs b/src/test/bench/shootout-fasta.rs
@@ -22,9 +22,7 @@ use std::io;
 use std::os;
 use std::rand::Rng;
 use std::rand;
-use std::result;
 use std::str;
-use std::uint;
 
 static LINE_LENGTH: uint = 60u;
 

diff --git a/src/test/bench/shootout-fibo.rs b/src/test/bench/shootout-fibo.rs
@@ -11,7 +11,6 @@
 extern mod extra;
 
 use std::int;
-use std::io;
 use std::os;
 
 fn fib(n: int) -> int {

diff --git a/src/test/bench/shootout-k-nucleotide-pipes.rs b/src/test/bench/shootout-k-nucleotide-pipes.rs
@@ -22,7 +22,6 @@ use std::io::ReaderUtil;
 use std::io;
 use std::option;
 use std::os;
-use std::result;
 use std::str;
 use std::task;
 use std::util;

diff --git a/src/test/bench/sudoku.rs b/src/test/bench/sudoku.rs
@@ -15,7 +15,6 @@ extern mod extra;
 use std::io::{ReaderUtil, WriterUtil};
 use std::io;
 use std::os;
-use std::u8;
 use std::uint;
 use std::unstable::intrinsics::cttz16;
 use std::vec;

diff --git a/src/test/codegen/scalar-function-call.rs b/src/test/codegen/scalar-function-call.rs
@@ -14,5 +14,5 @@ fn foo(x: int) -> int {
 
 #[no_mangle]
 fn test() {
-    let x = foo(10);
+    let _x = foo(10);
 }
diff --git a/src/test/debug-info/basic-types.rs b/src/test/debug-info/basic-types.rs
@@ -51,6 +51,8 @@
 // debugger:print f64
 // check:$15 = 3.5
 
+#[allow(unused_variable)];
+
 fn main() {
     let b: bool = false;
     let i: int = -1;

diff --git a/src/test/debug-info/borrowed-basic.rs b/src/test/debug-info/borrowed-basic.rs
@@ -62,6 +62,8 @@
 // debugger:print *f64_ref
 // check:$15 = 3.5
 
+#[allow(unused_variable)];
+
 fn main() {
     let bool_val: bool = true;
     let bool_ref: &bool = &bool_val;
@@ -110,4 +112,4 @@ fn main() {
     zzz();
 }
 
-fn zzz() {()}
+fn zzz() {()}
diff --git a/src/test/debug-info/borrowed-c-style-enum.rs b/src/test/debug-info/borrowed-c-style-enum.rs
@@ -24,6 +24,8 @@
 // debugger:print *the_c_ref
 // check:$3 = TheC
 
+#[allow(unused_variable)];
+
 enum ABC { TheA, TheB, TheC }
 
 fn main() {
@@ -39,4 +41,4 @@ fn main() {
     zzz();
 }
 
-fn zzz() {()}
+fn zzz() {()}
diff --git a/src/test/debug-info/borrowed-enum.rs b/src/test/debug-info/borrowed-enum.rs
@@ -24,6 +24,8 @@
 // debugger:print *univariant_ref
 // check:$3 = {4820353753753434}
 
+#[allow(unused_variable)];
+
 // The first element is to ensure proper alignment, irrespective of the machines word size. Since
 // the size of the discriminant value is machine dependent, this has be taken into account when
 // datatype layout should be predictable as in this case.
@@ -59,4 +61,4 @@ fn main() {
     zzz();
 }
 
-fn zzz() {()}
+fn zzz() {()}
diff --git a/src/test/debug-info/borrowed-managed-basic.rs b/src/test/debug-info/borrowed-managed-basic.rs
@@ -62,6 +62,7 @@
 // debugger:print *f64_ref
 // check:$15 = 3.5
 
+#[allow(unused_variable)];
 
 fn main() {
     let bool_box: @bool = @true;
@@ -111,4 +112,4 @@ fn main() {
     zzz();
 }
 
-fn zzz() {()}
+fn zzz() {()}
diff --git a/src/test/debug-info/borrowed-struct.rs b/src/test/debug-info/borrowed-struct.rs
@@ -45,7 +45,7 @@
 // debugger:print *unique_val_interior_ref_2
 // check:$10 = 26.5
 
-
+#[allow(unused_variable)];
 
 struct SomeStruct {
     x: int,
@@ -72,4 +72,4 @@ fn main() {
     zzz();
 }
 
-fn zzz() {()}
+fn zzz() {()}
diff --git a/src/test/debug-info/borrowed-tuple.rs b/src/test/debug-info/borrowed-tuple.rs
@@ -27,6 +27,8 @@
 // debugger:print *unique_val_ref
 // check:$4 = {-17, -22}
 
+#[allow(unused_variable)];
+
 fn main() {
     let stack_val: (i16, f32) = (-14, -19f32);
     let stack_val_ref: &(i16, f32) = &stack_val;
@@ -41,4 +43,4 @@ fn main() {
     zzz();
 }
 
-fn zzz() {()}
+fn zzz() {()}