-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not trigger
unused_{braces,parens}
lints with yield
- Loading branch information
Showing
3 changed files
with
44 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
#![feature(generator_trait)] | ||
#![feature(generators)] | ||
#![deny(unused_braces, unused_parens)] | ||
|
||
use std::ops::Generator; | ||
use std::pin::Pin; | ||
|
||
fn main() { | ||
let mut x = |_| { | ||
while let Some(_) = (yield) {} | ||
while let Some(_) = {yield} {} | ||
// Only warn these cases | ||
while let Some(_) = ({yield}) {} //~ ERROR: unnecessary parentheses | ||
while let Some(_) = {(yield)} {} //~ ERROR: unnecessary braces | ||
}; | ||
let _ = Pin::new(&mut x).resume(Some(5)); | ||
} |
26 changes: 26 additions & 0 deletions
26
src/test/ui/lint/issue-74883-unused-paren-baren-yield.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
error: unnecessary parentheses around `let` scrutinee expression | ||
--> $DIR/issue-74883-unused-paren-baren-yield.rs:13:29 | ||
| | ||
LL | while let Some(_) = ({yield}) {} | ||
| ^^^^^^^^^ help: remove these parentheses | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/issue-74883-unused-paren-baren-yield.rs:3:24 | ||
| | ||
LL | #![deny(unused_braces, unused_parens)] | ||
| ^^^^^^^^^^^^^ | ||
|
||
error: unnecessary braces around `let` scrutinee expression | ||
--> $DIR/issue-74883-unused-paren-baren-yield.rs:14:29 | ||
| | ||
LL | while let Some(_) = {(yield)} {} | ||
| ^^^^^^^^^ help: remove these braces | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/issue-74883-unused-paren-baren-yield.rs:3:9 | ||
| | ||
LL | #![deny(unused_braces, unused_parens)] | ||
| ^^^^^^^^^^^^^ | ||
|
||
error: aborting due to 2 previous errors | ||
|