Skip to content

Commit

Permalink
Dont abort on first macro error
Browse files Browse the repository at this point in the history
  • Loading branch information
bjorn3 committed Sep 2, 2017
1 parent 878013c commit 8bb7dba
Show file tree
Hide file tree
Showing 5 changed files with 139 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/libsyntax/ext/tt/macro_rules.rs
Expand Up @@ -172,7 +172,9 @@ fn generic_extension<'cx>(cx: &'cx mut ExtCtxt,
}

let best_fail_msg = parse_failure_msg(best_fail_tok.expect("ran no matchers"));
cx.span_fatal(best_fail_spot.substitute_dummy(sp), &best_fail_msg);
cx.span_err(best_fail_spot.substitute_dummy(sp), &best_fail_msg);
cx.trace_macros_diag();
DummyResult::any(sp)
}

// Note that macro-by-example's input is also matched against a token tree:
Expand Down
2 changes: 2 additions & 0 deletions src/test/ui/macros/assert_eq_trailing_comma.stderr
Expand Up @@ -4,3 +4,5 @@ error: unexpected end of macro invocation
12 | assert_eq!(1, 1,);
| ^

error: aborting due to previous error

2 changes: 2 additions & 0 deletions src/test/ui/macros/assert_ne_trailing_comma.stderr
Expand Up @@ -4,3 +4,5 @@ error: unexpected end of macro invocation
12 | assert_ne!(1, 2,);
| ^

error: aborting due to previous error

55 changes: 55 additions & 0 deletions src/test/ui/macros/trace_faulty_macros.rs
@@ -0,0 +1,55 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// compile-flags: -Z trace-macros

#![recursion_limit="4"]

macro_rules! my_faulty_macro {
() => {
my_faulty_macro!(bcd);
};
}

macro_rules! nested_pat_macro {
() => {
nested_pat_macro!(inner);
};
(inner) => {
a | b | 1 ... 3 | _
}
}

macro_rules! my_recursive_macro {
() => {
my_recursive_macro!();
};
}

macro_rules! my_macro {
() => {

};
}

fn main() {
my_faulty_macro!();
nested_pat_macro!();
my_recursive_macro!();
test!();
non_exisiting!();
derive!(Debug);
}

#[my_macro]
fn use_bang_macro_as_attr(){}

#[derive(Debug)]
fn use_derive_macro_as_attr(){}
77 changes: 77 additions & 0 deletions src/test/ui/macros/trace_faulty_macros.stderr
@@ -0,0 +1,77 @@
error: no rules expected the token `bcd`
--> $DIR/trace_faulty_macros.rs:17:26
|
17 | my_faulty_macro!(bcd);
| ^^^
...
43 | my_faulty_macro!();
| ------------------- in this macro invocation

note: trace_macro
--> $DIR/trace_faulty_macros.rs:43:5
|
43 | my_faulty_macro!();
| ^^^^^^^^^^^^^^^^^^^
|
= note: expanding `my_faulty_macro! { }`
= note: to `my_faulty_macro ! ( bcd ) ;`
= note: expanding `my_faulty_macro! { bcd }`

error: expected expression, found `_`
--> $DIR/trace_faulty_macros.rs:26:27
|
26 | a | b | 1 ... 3 | _
| ^
...
44 | nested_pat_macro!();
| -------------------- in this macro invocation

error: recursion limit reached while expanding the macro `my_recursive_macro`
--> $DIR/trace_faulty_macros.rs:32:9
|
32 | my_recursive_macro!();
| ^^^^^^^^^^^^^^^^^^^^^^
...
45 | my_recursive_macro!();
| ---------------------- in this macro invocation
|
= help: consider adding a `#![recursion_limit="8"]` attribute to your crate

note: trace_macro
--> $DIR/trace_faulty_macros.rs:45:5
|
45 | my_recursive_macro!();
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: expanding `my_recursive_macro! { }`
= note: to `my_recursive_macro ! ( ) ;`
= note: expanding `my_recursive_macro! { }`
= note: to `my_recursive_macro ! ( ) ;`
= note: expanding `my_recursive_macro! { }`
= note: to `my_recursive_macro ! ( ) ;`
= note: expanding `my_recursive_macro! { }`
= note: to `my_recursive_macro ! ( ) ;`
= note: expanding `my_recursive_macro! { }`
= note: to `my_recursive_macro ! ( ) ;`

note: trace_macro
--> $DIR/trace_faulty_macros.rs:43:5
|
43 | my_faulty_macro!();
| ^^^^^^^^^^^^^^^^^^^
|
= note: expanding `my_faulty_macro! { }`
= note: to `my_faulty_macro ! ( bcd ) ;`
= note: expanding `my_faulty_macro! { bcd }`

note: trace_macro
--> $DIR/trace_faulty_macros.rs:44:5
|
44 | nested_pat_macro!();
| ^^^^^^^^^^^^^^^^^^^^
|
= note: expanding `nested_pat_macro! { }`
= note: to `nested_pat_macro ! ( inner ) ;`
= note: expanding `nested_pat_macro! { inner }`
= note: to `a | b | 1 ... 3 | _`

0 comments on commit 8bb7dba

Please sign in to comment.