Skip to content

Commit

Permalink
Separates inner attributes from code during doctest parsing.
Browse files Browse the repository at this point in the history
  • Loading branch information
repnop authored and QuietMisdreavus committed Nov 1, 2018
1 parent 43b65b5 commit cd407df
Showing 1 changed file with 37 additions and 23 deletions.
60 changes: 37 additions & 23 deletions src/librustdoc/test.rs
Expand Up @@ -378,7 +378,7 @@ pub fn make_test(s: &str,
dont_insert_main: bool,
opts: &TestOptions)
-> (String, usize) {
let (crate_attrs, everything_else) = partition_source(s);
let (crate_attrs, everything_else, crates) = partition_source(s);
let everything_else = everything_else.trim();
let mut line_offset = 0;
let mut prog = String::new();
Expand Down Expand Up @@ -409,38 +409,47 @@ pub fn make_test(s: &str,
use crate::syntax_pos::FileName;

let filename = FileName::Anon;
let source = s.to_owned();
let source = crates + &everything_else;
let sess = ParseSess::new(FilePathMapping::empty());

let mut parser = parse::new_parser_from_source_str(&sess, filename, source);

let mut found_main = false;
let mut found_extern_crate = cratename.is_none();

while let Ok(Some(item)) = parser.parse_item() {
if !found_main {
if let ast::ItemKind::Fn(..) = item.node {
if item.ident.as_str() == "main" {
found_main = true;
loop {
match parser.parse_item() {
Ok(Some(item)) => {
if !found_main {
if let ast::ItemKind::Fn(..) = item.node {
if item.ident.as_str() == "main" {
found_main = true;
}
}
}
}
}

if !found_extern_crate {
if let ast::ItemKind::ExternCrate(original) = item.node {
// This code will never be reached if `cratename` is none because
// `found_extern_crate` is initialized to `true` if it is none.
let cratename = cratename.unwrap();
if !found_extern_crate {
if let ast::ItemKind::ExternCrate(original) = item.node {
// This code will never be reached if `cratename` is none because
// `found_extern_crate` is initialized to `true` if it is none.
let cratename = cratename.unwrap();

match original {
Some(name) => found_extern_crate = name.as_str() == cratename,
None => found_extern_crate = item.ident.as_str() == cratename,
}
}
}

match original {
Some(name) => found_extern_crate = name.as_str() == cratename,
None => found_extern_crate = item.ident.as_str() == cratename,
if found_main && found_extern_crate {
break;
}
}
}

if found_main && found_extern_crate {
break;
Ok(None) => break,
Err(mut e) => {
e.cancel();
break;
}
}
}

Expand Down Expand Up @@ -474,9 +483,10 @@ pub fn make_test(s: &str,
}

// FIXME(aburka): use a real parser to deal with multiline attributes
fn partition_source(s: &str) -> (String, String) {
fn partition_source(s: &str) -> (String, String, String) {
let mut after_header = false;
let mut before = String::new();
let mut crates = String::new();
let mut after = String::new();

for line in s.lines() {
Expand All @@ -490,12 +500,16 @@ fn partition_source(s: &str) -> (String, String) {
after.push_str(line);
after.push_str("\n");
} else {
if trimline.starts_with("#[macro_use] extern crate")
|| trimline.starts_with("extern crate") {
crates.push_str(line);
}
before.push_str(line);
before.push_str("\n");
}
}

(before, after)
(before, after, crates)
}

pub trait Tester {
Expand Down

0 comments on commit cd407df

Please sign in to comment.