Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
std::at_vec: Fix segfault on overflow when resizing ~[@t]
Easy to reproduce: let mut v = ~[@1]; v.resize(-1); // success a.k.a silent failure v.push(@2); // segfault
- Loading branch information
blake2-ppc
committed
Sep 17, 2013
1 parent
6e538ed
commit e211888
Showing
2 changed files
with
16 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e211888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/blake2-ppc/rust/commit/e211888407db32fcec53f4fa9eb84acdbdf59f87
e211888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging blake2-ppc/rust/hazards-on-overflow = e211888 into auto
e211888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blake2-ppc/rust/hazards-on-overflow = e211888 merged ok, testing candidate = d5e9033
e211888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1516
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1519
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/625
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/625
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1535
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/626
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/626
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1535
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/626
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/626
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/707
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1520
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/625
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/626
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/1304
e211888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = d5e9033