Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
libcollection: generalize StrVector to AsSlice<Str>.
The impl for [T] also works as impl for slices in general. By generalizing the impl of StrVector for Vec<Str> to that for AsSlice<Str>, it becomes much more generic. Once Iterable is implemented, we will prefer it to AsSlice. But the with_capacity() part might become tricky. Signed-off-by: NODA, Kai <nodakai@gmail.com>
- Loading branch information
Showing
1 changed file
with
75 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef3b88c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at nodakai@ef3b88c
ef3b88c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nodakai/rust/generalize-strvector = ef3b88c into auto
ef3b88c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodakai/rust/generalize-strvector = ef3b88c merged ok, testing candidate = 3959013
ef3b88c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2417
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2415
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2408
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2415
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2409
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2408
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2408
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2412
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2405
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2404
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2407
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2069
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2065
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/2071
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/908
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/902
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/897
ef3b88c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 3959013