Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude intel SVML functions from missing intrinsics report #1253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jhorstmann
Copy link
Contributor

Intel's Short Vector Math Library (SVML) defines optimized math functions which do not directly map to single cpu instructions but rather to a sequence of instructions. Exclude these from the missing intrinsics report so that it is much easier to see which real instructions are still missing for example for full AVX512F support.

This also updates the intrinsics data file to version 3.6

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon.

Please see the contribution instructions for more information.

@@ -155,7 +156,7 @@ fn verify_all_signatures() {
// https://software.intel.com/sites/landingpage/IntrinsicsGuide/#
//
// Open up the network console and you'll see an xml file was downloaded
// (currently called data-3.4.xml). That's the file we downloaded
// (currently called data-3.6.xml). That's the file we downloaded
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring pack files this update will grow the repo size by 6.74 MB. With pack files, it will likely be a bit smaller, though possibly not by much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I did not consider the size. If that is a concern I could revert and rebase adding this file. It could be added once there are actual plans to implement to implement for example the VNNI or FP16 extensions. My goal is to work on avx512f and avx512vl for now, especially masked loads/stores.

@bors
Copy link
Contributor

bors commented Feb 18, 2023

☔ The latest upstream changes (presumably 35b0b1e) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants