Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use platform dependent c_char instead of hardcoded i8 #354

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mike-kfed
Copy link

this should fix issue #351

I am willing to adapt to your preferences, but this works for me (tm)

Copy link

@crunchy234 crunchy234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to get this in so that we can continue to use our linux arm instances

@seddonm1
Copy link
Contributor

I have tested this on both x86_64 and aarch64 and it works. Would be great to see it merged.

@skeet70 skeet70 mentioned this pull request Jul 25, 2023
@Dirreke
Copy link

Dirreke commented Feb 3, 2024

And also this @termoshtt .Thanks very much!

@leecbaker
Copy link

@mike-kfed Thanks for putting this together!

Is there a reason to use libc::c_char instead of std::ffi::c_char or std::os::raw::c_char?

I think either of those may be equivalent, and avoids adding the dependency on libc.

@mike-kfed
Copy link
Author

@leecbaker honestly I just followed the advice found in an open issue and "just wanted to make it work" (tm) ;)

I'll remove the dependency on libc, you are correct the other Rust std lib c_char definitions should be fine too.

@daniestevez
Copy link

I'm using this in armv7-unknown-linux-gnueabihf and it works too.

@FylmTM
Copy link

FylmTM commented May 14, 2024

Encountered this issue today when our CI was switched to AWS C7g instances, that are using ARM Graviton3 processors.

It seems that this PR fixes the issue.
Would it possible to merge it, so that it can become available in upstream? 👀
Thankie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants