Support is_x11 and is_wayland on EventLoop #3672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
requested changes
May 3, 2024
|
New traits then (a copy of these other than the name)? |
|
Yes. Which is unfortunate, but it will prevent errors if someone tries to add API for the |
notgull
approved these changes
May 20, 2024
kchibisov
requested changes
May 21, 2024
src/changelog/unreleased.md
Outdated
| @@ -12,6 +12,7 @@ on how to add them: | |||
| ### Added | |||
|
|
|||
| - Add `Window::turbo()`, implemented on X11, Wayland, and Web. | |||
| - Implement `ActiveEventLoopExtWayland` and `ActiveEventLoopExtX11` for `EventLoop`. | |||
There was a problem hiding this comment.
This is not correct anymore. It should mention the new traits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersWinit v0.30 does not allow testing
is_waylandon anEventLoop(but only on anActiveEventLoop), though this appears to be possible. This is an issue for me.The trait names
ActiveEventLoopExtWaylandandActiveEventLoopExtX11are now inaccurate (may cause issues with future additional functionality?), but this is the most straightforward solution.Fixes #3670