Add more specific error messages for X11 failed initialization

[notgull]

This ensures that, when X11 initialization fails, we know exactly why.

cc #3671

Signed-off-by: John Nunley dev@notgull.net

• Tested on all platforms changed
• Added an entry to the changelog module if knowledge of this change could be valuable to users
• Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
• Created or updated an example program if it would help users understand this functionality
• Updated feature matrix, if new features were added or implemented

[kchibisov]

In general, I think the better approach is to add proper annotation for the errors themselves.

Not sure how visible the tracing stuff would be when you actually boil from winit and likely exit, etc.

[notgull]

In general, I think the better approach is to add proper annotation for the errors themselves.

Agreed, but this would require a breaking change.

[kchibisov]

But X11 error is not a public API, so you'd just change the internal layout?

[notgull]

Huh, I thought it was? Okay then, this can be fixed

[kchibisov]

Huh, I thought it was? Okay then, this can be fixed

Everything inside the platform_impl is private, only platform is public.

[kchibisov]

Shouldn't we do it uniformly with the rest of the errors? Since we generally point to platform_impl from here?

Though, in the current state of things it doesn't matter that much.

[notgull]

That would add a lot of additional code for little benefit

[kchibisov]

I'm still not entirely sure what to do with this and I think it'll add more boilerplate when splitting backends...

So, I'll keep it around for now because the change is rather small internally and provides no practical value, since all the info available in e.g. strace if you debug things like failed to load dynamic library.