Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix drag glitch when dragging across monitor boundary #3693

Merged

Conversation

BillGoldenWater
Copy link
Contributor

@BillGoldenWater BillGoldenWater commented May 9, 2024

On macOS, when dragging across monitor boundary with a different scale factor, the QueuedEvent::ScaleFactorChanged event will be emit.

When process this event, will unconditionally set the content size, which would cause some glitch.


Because the event is emitted with suggested_size set to current frame size.

So, if the user hasn't requested a size change, the call to setContentSize wouldn't actually change the size.

So, change to only call setContentSize if the user has requested a size change.


  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@kchibisov kchibisov merged commit e108fa2 into rust-windowing:master May 23, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants