test: Exclude sys/sysmacros.h on FreeBSD #2181
Conversation
Fixes built issue on FreeBSD
| @@ -28,8 +28,11 @@ | |||
| #include <string.h> | |||
| #include <errno.h> | |||
| #ifndef __APPLE__ | |||
| #elif | |||
| #ifndef __FreeBSD__ | |||
There was a problem hiding this comment.
I am skeptical of code that CI does not exercise which will rot over time. Is there some other way to approach this?
There was a problem hiding this comment.
Edit: My bad, it's GNU libc specific
https://github.com/s3fs-fuse/s3fs-fuse/actions/runs/5187421517/jobs/9350370578?pr=2181#step:6:262
There was a problem hiding this comment.
Could we call system to invoke mknod instead?
There was a problem hiding this comment.
Thinking about this some more I think the #ifdef is fine. But CI is broken so we cannot merge this.
There was a problem hiding this comment.
@diizzyy Could you move forward with this PR?
There was a problem hiding this comment.
I'll try to have a look again next week, unfortunately I don't have a Linux box available so I'm not sure why it fails.
Fixes build issue on FreeBSD