rmlint: fix the build on older Darwin systems #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
instead of MAC_OS_X_VERSION_10_7 use 1070 |
barracuda156
force-pushed
the
rmlint-darwin
branch
from
10cf452
to
e9133b8
Compare
barracuda156
force-pushed
the
rmlint-darwin
branch
from
e9133b8
to
7ee224e
Compare
|
@sahib Could you please take a look at this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
rmlintbuild for 10.5.8 and 10.6.It contains two part, which come from:
P. S. There is also another problem related to how SCons build system works – trying to build a FAT binary on Leopard fails, for example, because arch flags get ignored. I solve it like this (for Macports): https://github.com/macports/macports-ports/pull/15003/files#diff-d43b1faa4b64984e308f2d41fddfd09fb559868da27208ff41417d636a4c7d20
I don’t know how to make a similar fix in the source code that gonna work without Macports assistance.