Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Instructions for Ubuntu Build Dependencies #585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nathanbrauer
Copy link

  • Replaced "still ships" with "ships", as Ubuntu 14.04 LTS is EOL
  • Added sudo to apt-get commands as required in most Ubuntu environments
  • Replaced python-cairo with python3-cairo (python-cairo no longer exists resulting in E: Unable to locate package python-cairo error message).

@cebtenzzre
Copy link
Collaborator

I think you accidentally broke the "ships an official package" link. Also, could you rebase this on master? I'm working on a 2.10.2 release and this seems like it's worth including.

@nathanbrauer
Copy link
Author

Fixed the auto-added back-ticks...

To be clear on the rebase, you want me to rebase master into this feature branch? (This feature branch was created from develop.)

Do you still want the pull request targeting develop? Or do you want a new pull request targeting master as well?

PS: A CONTRIBUTIONS file explaining pull request expectations would be helpful :)

@cebtenzzre
Copy link
Collaborator

I'd like you to edit the pull request to target master, squash your commits, and rebase the feature branch onto the tip of master. That way I don't need to cherry-pick it. I will merge master into develop eventually, so I don't need another PR.

@nathanbrauer nathanbrauer force-pushed the feature/manual-ubuntu-build-dependencies branch from aa3b8d2 to 7064a68 Compare August 20, 2022 08:18
@nathanbrauer nathanbrauer changed the base branch from develop to master August 20, 2022 08:18
@nathanbrauer
Copy link
Author

There you go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants