Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an interface for refreshing visitor access token using direct ID token #1019

Merged
merged 3 commits into from
May 23, 2024
Merged

Add an interface for refreshing visitor access token using direct ID token #1019

merged 3 commits into from
May 23, 2024
+95 −12

Conversation

andrews-moc
Copy link
Contributor

@andrews-moc andrews-moc commented Apr 17, 2024 •
edited

MOB-3204
Build fails because Core SDK changes should be released first.

What was solved?

  • Add an interface for refreshing visitor access token using direct ID token
  • Example App: update Authenticate/De-authenticate button state each time onResume() is called

Release notes:
Add an interface for refreshing visitor access token using direct ID token

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

@andrews-moc andrews-moc force-pushed the feature/MOB-3204_refresh_id_token_interface branch 2 times, most recently from 04341e8 to 9f1711b Compare April 29, 2024 14:29
@andrews-moc
Add an interface for refreshing visitor access token using direct ID …
92a5294 
…token

Example App: update Authenticate/De-authenticate button state each time onResume() is called

MOB-3204
@andrews-moc
Add refresh DirectID token possibility to Widgets Example App
2623975 
MOB-3274
@andrews-moc andrews-moc force-pushed the feature/MOB-3204_refresh_id_token_interface branch from da20aee to 6c59554 Compare May 23, 2024 13:07
@andrews-moc andrews-moc force-pushed the feature/MOB-3204_refresh_id_token_interface branch from 6c59554 to 332e8f0 Compare May 23, 2024 13:26
@andrews-moc andrews-moc merged commit 275a57e into development May 23, 2024
7 checks passed
@andrews-moc andrews-moc deleted the feature/MOB-3204_refresh_id_token_interface branch May 23, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pelkar Pelkar Pelkar approved these changes

@gugalo gugalo gugalo approved these changes

@DavDo DavDo DavDo approved these changes

@AndriiHorishniiMOC AndriiHorishniiMOC AndriiHorishniiMOC approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@andrews-moc @Pelkar @gugalo @DavDo @AndriiHorishniiMOC