Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip camera #1021

Merged
merged 7 commits into from
May 23, 2024
Merged

Flip camera #1021

merged 7 commits into from
May 23, 2024

Conversation

AndriiHorishniiMOC
Copy link
Contributor

Jira issue:
https://glia.atlassian.net/browse/ MOB-3244

What was solved?
Added the ability to change the visitor's camera from the front to the back camera.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

DavDo
DavDo reviewed Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@DavDo DavDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!
Could you please extend EngagementRepositoryTest with the tests for newly added functions and maybe getters.

widgetssdk/src/main/res/layout/visitor_video_floating_view.xml Outdated Show resolved Hide resolved
widgetssdk/src/main/java/com/glia/widgets/engagement/domain/IsVisitorCanFlipCameraUseCase.kt Outdated Show resolved Hide resolved
@AndriiHorishniiMOC AndriiHorishniiMOC force-pushed the MOB-3244_flip_camera branch 3 times, most recently from c1041de to 8b9e67e Compare May 3, 2024 10:35
Pelkar
Pelkar approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@Pelkar Pelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

widgetssdk/src/main/res/drawable/ic_flip_visitor_camera.xml Show resolved Hide resolved
DavDo
DavDo approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@DavDo DavDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriiHorishniiMOC AndriiHorishniiMOC force-pushed the MOB-3244_flip_camera branch 3 times, most recently from 87d69df to 8bb447d Compare May 17, 2024 15:00
@AndriiHorishniiMOC AndriiHorishniiMOC changed the title Mob 3244 flip camera Flip camera May 20, 2024
@AndriiHorishniiMOC AndriiHorishniiMOC requested a review from a team May 22, 2024 08:51
kadriiiii
kadriiiii approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@kadriiiii kadriiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments look good to me!

@AndriiHorishniiMOC AndriiHorishniiMOC force-pushed the MOB-3244_flip_camera branch 2 times, most recently from 99d1934 to 896475b Compare May 23, 2024 18:42
@AndriiHorishniiMOC
Added the ability to flip the visitor's camera
1ba8ccf 
Added the ability to change the visitor's camera from the front to the back camera
MOB-3244
@AndriiHorishniiMOC
Added unified theme for the flip camera button
55ec8cb 
MOB-3283
@AndriiHorishniiMOC
Fix: Video views do not appear during a video call
ac6d6d4 
It seems that the startWithItem does not work well when called after some map functions. The combined visitor and operator media events can never occur in that case.

MOB-3327
@AndriiHorishniiMOC
Minor improvements
2248e37 
Added logging for an extra case when it isn’t possible to flip the camera in an ordinary way.
Updated unit tests according to the new functionality.

MOB-3348
@AndriiHorishniiMOC AndriiHorishniiMOC merged commit ef982d2 into development May 23, 2024
7 checks passed
@AndriiHorishniiMOC AndriiHorishniiMOC deleted the MOB-3244_flip_camera branch May 23, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pelkar Pelkar Pelkar approved these changes

@DavDo DavDo DavDo approved these changes

@kadriiiii kadriiiii kadriiiii approved these changes

@andrews-moc andrews-moc andrews-moc approved these changes

@gugalo gugalo Awaiting requested review from gugalo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@AndriiHorishniiMOC @Pelkar @DavDo @kadriiiii @andrews-moc