Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ADA support for the flip camera button #1026

Merged
merged 2 commits into from
May 17, 2024
Merged

Added ADA support for the flip camera button #1026

merged 2 commits into from
May 17, 2024

Conversation

AndriiHorishniiMOC
Copy link
Contributor

Jira issue:
https://glia.atlassian.net/browse/MOB-3293

What was solved?
Added ADA support for the flip camera button

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from Android SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

Pelkar
Pelkar requested changes May 17, 2024
View reviewed changes
widgetssdk/src/main/res/values/new_strings.xml Outdated
@@ -146,6 +146,8 @@
<string name="call_buttons_chat_badge_value_multiple_items_accessibility_label">@string/glia_call_chat_other_content_description</string>
<string name="call_buttons_chat_badge_value_single_item_accessibility_label">@string/glia_call_chat_one_content_description</string>
<string name="general_you">@string/glia_call_visitor_video_on_hold_text</string>
<string name="call_visitor_video_flip_to_back_camera_button_accessibility_label">Switch to back camera</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outdated, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. For some reason, I couldn't push fixed yesterday. But now it is fixed.

@AndriiHorishniiMOC
Copy link
Contributor Author

AndriiHorishniiMOC commented May 17, 2024 •
edited

Hey! I made changes and added an accessibility event. I believe, in this case, it is better to ask you for a review again.

@AndriiHorishniiMOC AndriiHorishniiMOC merged commit 87d69df into MOB-3244_flip_camera May 17, 2024
5 of 7 checks passed
@AndriiHorishniiMOC AndriiHorishniiMOC deleted the MOB-3293_flip_button_ADA branch May 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavDo DavDo DavDo approved these changes

@andrews-moc andrews-moc andrews-moc approved these changes

@Pelkar Pelkar Awaiting requested review from Pelkar

@gugalo gugalo Awaiting requested review from gugalo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@AndriiHorishniiMOC @Pelkar @gugalo @DavDo @andrews-moc