Skip to content

Commit

Permalink
initial commit for closure_compiler bazel build (apache#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
sambhajis-gdb authored and ashishk-1 committed Aug 6, 2019
1 parent bf5935c commit ba30fd0
Show file tree
Hide file tree
Showing 5 changed files with 65 additions and 2 deletions.
17 changes: 17 additions & 0 deletions bazel/closure_compiler.bzl
@@ -0,0 +1,17 @@
def closure_compiler_gen(name, js_dir=[],srcs=[],js_includes=[],entry_points=[], externs=[],opt=True):
print("name ",name)
print("js_dir ",js_dir)
print("srcs ",srcs)
print("js_includes ",js_includes)
print("entry_points ",entry_points)
print("externs ",externs)
print("opt ",opt)

native.genrule(
name = "compiled_" + name+("_opt.js" if opt else "_dbg.js"),
srcs = srcs,
outs = [name],
cmd = ""
)


8 changes: 8 additions & 0 deletions bazel/repositories.bzl
Expand Up @@ -38,6 +38,7 @@ LIBJPEG_TURBO_COMMIT = "14eba7addfdcf0699970fcbac225499858a167f2"
APR_COMMIT = "a194e7afd16d2bd88c5394dfb6d066614161b1ed"
APRUTIL_COMMIT = "13ed779e56669007dffe9a27ffab3790b59cbfaa"
SERF_COMMIT = "95cf7547361549e192ac34d94d44c01c7a57b642"
CLOSURE_LIBRARY_COMMIT = "cd0e79408e4ec90e0da2eaee846a3400fae30445"

def mod_pagespeed_dependencies():
http_archive(
Expand Down Expand Up @@ -466,3 +467,10 @@ cc_binary(
sha256 = "bcc7ddc4b82bf76ba862261cdb580db044ff62dcd523f8eb6acde87518b10257",
)

http_archive(
name = "closure_library",
strip_prefix = "closure-library-%s" % CLOSURE_LIBRARY_COMMIT,
url = "https://github.com/google/closure-library/archive/%s.tar.gz" % CLOSURE_LIBRARY_COMMIT,
sha256 = "bd5966814e6fdced42e97f8461fcbae52849cf589292a1c589585fcd9fdb3cd2",
)

5 changes: 4 additions & 1 deletion net/instaweb/BUILD
Expand Up @@ -7,5 +7,8 @@ cc_library(
"public/global_constants.h",
],
visibility = ["//visibility:public"],
deps = ["//pagespeed/kernel/base:pagespeed_base_core"]
deps = [
"//pagespeed/kernel/base:pagespeed_base_core",
"//third_party/closure:download_closure",
]
)
23 changes: 22 additions & 1 deletion net/instaweb/rewriter/BUILD
Expand Up @@ -4,10 +4,10 @@ load(
"pagespeed_cc_test_library",
)
load("//bazel:data2c.bzl", "data2c_gen2", "data2c_gen2_opt")
load("//bazel:closure_compiler.bzl", "closure_compiler_gen")

licenses(["notice"]) # Apache 2


genrule(
name = "csp_directive_gperf",
srcs = ["csp_directive.gperf"],
Expand Down Expand Up @@ -69,6 +69,27 @@ data2c_gen2(
],
)

closure_compiler_gen(
name = "console_js",
srcs = [
"pagespeed/system/console.js",
],
js_dir = "system",
js_includes = [
"pagespeed/system/console_start.js",
],
externs = [
"pagespeed/system/js_externs.js",
"third_party/closure/externs/google_visualization_api.js",
],
entry_points = [
"goog:pagespeed.Console",
"goog:pagespeed.statistics",
],
opt = False,
)


data2c_gen2_opt(
name = "data2c_generated",
srcs = [
Expand Down
14 changes: 14 additions & 0 deletions third_party/closure/BUILD
@@ -0,0 +1,14 @@
licenses(["notice"]) # Apache 2

genrule(
name = 'compiler_script',
tools = ["download.sh"],
outs = ["compiler"],
cmd = ('./$(location download.sh) $@'),
)

cc_library(
name = "download_closure",
data = [":compiler_script"],
visibility = ["//visibility:public"],
)

0 comments on commit ba30fd0

Please sign in to comment.