Fix for #2873 - CSRF Exception after adding to Collections/Sharing

[jgondron]

• Found the root issue is related to turbolinks + jquery-ujs + a button that uses ajax to post. This may also fix Adding existing works to existing collection fails #1191. Adding a call to refresh the CSRF tokens in the rendered DOM after turbolinks loads fixes it.

Related to rails/jquery-ujs#456

@samvera/hyrax-code-reviewers

[no-reply]

Looks great! Thanks for tracking this down and getting this in.

Can we confirm whether this does close #1191.

I'd also like to get a regression test in for both tickets. Both seem like basic functionality that we could and should be testing.

[elrayle]

@jgondron You don't say so in the PR message, but doesn't this fix Issue #2873?

[elrayle]

I did some testing with this branch and was able to remove the data: { turbolinks: false } for app/views/hyrax/my/_collection_action_menu.html.erb for the hyrax.edit_dashboard_collection_path(id) link. I confirmed it got the invalid token error without the change in this PR and did not when using the change in this PR.

[elrayle]

@no-reply The scenario described in issue #1191 was fixed using a different method than turning off turbo links, so I am not able to directly create a regression test showing the exception happening before this PR's fix and not happening once the PR's fix is applied.

I added a test for the scenario described in Issue #2873 (see commit). But I wasn't able to recreate the exception without this PR's fix.

I was able to verify this PR's fix with another scenario and was able to remove the code that turned off turbolinks. (see commit)

Are you good with merging this PR? It is an excellent fix that I think will really put a dent in our turbolinks woes.