Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prior code buggy, ineffective. #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prior code buggy, ineffective. #70

wants to merge 1 commit into from

Conversation

devayes
Copy link
Contributor

@devayes devayes commented Jul 5, 2014

Echoing output before headers, this (from original source) is more simple and works. If the cookie does not exist, respond with 304 Not Modified (ie: cached, evercookie.js: line #446 )

Echoing output before headers, this (from original source) is more simple and works. If the cookie does not exist, respond with 304 Not Modified (ie: cached, evercookie.js: line #446 )
@samyk
Copy link
Owner

samyk commented Sep 16, 2014

Hi @devayes, it looks like this was changed primarily in this commit:
commit e3bc6c6
Author: Tom McKenzie tom@chillidonut.com
Date: Mon Jun 18 13:36:42 2012 +1000

Return blank 500 error when apache_request_headers doesn't exist
(prevents evercookie from being set to the PHP error message)

I'd investigate/document why it changed dramatically further before we change all the code in this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants