refactor: use PKG_VERSION from @sanity/pkg-utils instead of manua…

…lly regexing `SANITY_VERSION` (#6078) * refactor: use `PKG_VERSION` from `@sanity/pkg-utils` instead of manually regexing `SANITY_VERSION` * chore(sanity): remove unused script (#6090) --------- Co-authored-by: Bjørge Næss <bjoerge@gmail.com>
sanity-io · Mar 21, 2024 · fa717ab · fa717ab
1 parent 418e78a
commit fa717ab
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 102 deletions.
diff --git a/packages/sanity/package.json b/packages/sanity/package.json
@@ -181,13 +181,10 @@
     "clean": "rimraf _internal.js cli.js desk.js lib presentation.js router.js",
     "coverage": "jest --coverage",
     "lint": "eslint .",
-    "prepublishOnly": "run-s write:version write:ui-version",
     "test": "pkg-utils --strict && jest",
     "test:ct": "playwright test -c playwright-ct.config.ts",
     "watch": "pkg-utils watch --tsconfig tsconfig.lib.json",
-    "write:playwright-report-as-pr-comment": "node -r esbuild-register playwright-ct/scripts/parsePlaywrightReportJson.ts",
-    "write:ui-version": "node -r esbuild-register scripts/writeRequiredUIVersion.ts",
-    "write:version": "node -r esbuild-register scripts/writeVersion.ts"
+    "write:playwright-report-as-pr-comment": "node -r esbuild-register playwright-ct/scripts/parsePlaywrightReportJson.ts"
   },
   "dependencies": {
     "@dnd-kit/core": "^6.0.5",

diff --git a/packages/sanity/scripts/writeRequiredUIVersion.ts b/packages/sanity/scripts/writeRequiredUIVersion.ts
diff --git a/packages/sanity/scripts/writeVersion.ts b/packages/sanity/scripts/writeVersion.ts
diff --git a/packages/sanity/src/core/requiredSanityUiVersion.ts b/packages/sanity/src/core/requiredSanityUiVersion.ts
diff --git a/packages/sanity/src/core/version.ts b/packages/sanity/src/core/version.ts
@@ -1,10 +1,6 @@
 /**
- * TODO: rename to `VERSION`
- *
- *
+ * This version is provided by `@sanity/pkg-utils` at build time
  * @hidden
  * @beta
  */
-// This string is overwritten by prepublish script with `.version` from package.json
-// The version you see here is only read in monorepo development
-export const SANITY_VERSION = '0.0.0-development' as string
+export const SANITY_VERSION = process.env.PKG_VERSION || ('0.0.0-development' as string)
diff --git a/turbo.json b/turbo.json
@@ -1,7 +1,7 @@
 {
   "$schema": "https://turbo.build/schema.json",
-   // This is probably overkill, this will segment between GH actions and everything else for now.
-  "globalEnv": ["OS", "RUNNER_OS"],
+   // All environment variables that should invalidate a cached build needs to be declared here
+  "globalEnv": ["OS", "RUNNER_OS", "PKG_FILE_PATH", "PKG_FORMAT", "PKG_RUNTIME", "PKG_VERSION"],
   // These root workspace files are reused in workspaces and may affect their build output
   "globalDependencies": [
     ".babelrc",