feat(core): fetch structure tool settings from backend #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Mar 7, 2024 5:05 PM (UTC)
|
cngonzalez
commented
Mar 6, 2024
| import {type KeyValueStore, type KeyValueStoreValue} from './types' | ||
|
|
||
| /** @internal */ | ||
| export function createKeyValueStore(): KeyValueStore { | ||
| const storageBackend = resolveBackend() |
There was a problem hiding this comment.
@jtpetty has recommended we fall back to localStorage if the API is not available here. I've not included it in this PR since I didn't find a trivial way to deal with the asynchronous state of pinging the backend from within the resourceCache context. Hopefully it's possible.
cngonzalez
commented
Mar 6, 2024
packages/sanity/src/core/store/key-value/backends/localStorage.ts
Outdated
Show resolved
Hide resolved
cngonzalez
commented
Mar 6, 2024
cngonzalez
commented
Mar 6, 2024
bjoerge
reviewed
Mar 6, 2024
bjoerge
approved these changes
Mar 7, 2024
binoy14
approved these changes
Mar 7, 2024
| '{"by":[{"field":"name","direction":"asc"}],"extendedProjection":"name"}', | ||
| ) | ||
| const nameResult = await sanityClient.request({ | ||
| uri: `/users/me/keyvalue/${SORT_KEY}`, |
There was a problem hiding this comment.
🤔 probably need to set version to vX to fix the failing tests?
There was a problem hiding this comment.
oh maybe thinking about it more, is it because it's hitting prod?
There was a problem hiding this comment.
Do the e2e tests in CI take place in staging?
There was a problem hiding this comment.
no they are against production
There was a problem hiding this comment.
Thought so! Can certainly change the API version if we want to, but that'll be (hopefully) be a short lived change (and won't currently fix tests 😅 )
cngonzalez
changed the base branch from
feat/fetch-settings-from-backend
to
next
cngonzalez
changed the base branch from
next
to
feat/fetch-settings-from-backend
cngonzalez
merged commit 9c1d928
into
feat/fetch-settings-from-backend
37 of 39 checks passed
cngonzalez
added a commit
that referenced
this pull request
Mar 8, 2024
cngonzalez
added a commit
that referenced
this pull request
Mar 12, 2024
cngonzalez
added a commit
that referenced
this pull request
Mar 14, 2024
cngonzalez
added a commit
that referenced
this pull request
Mar 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
* feat(core): fetch structure tool settings from backend (#5901) * feat(core): store recent search history in backend (#5940) * feat(core): fetch inspect mode from backend (#5938) * chore: update studio version for production-ready cellar (#5993) * fix: prevent key value store from firing setKey for each open subscription (#5997) * fix: update tests to match api (#6000) * fix: update tests to match api * fix: comment out flaky tests for now * chore: remove unused resolve logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scaffolds a Dataloader that hits an API endpoint for user settings -- in this case, specifically those settings relevant to structure tools.
This is meant to be just a scaffold. In the following day, please expect:
What to review
The Dataloader backend specifically -- does it work as we expect? Any gotchas? Are errors being handled correctly?
Testing
End-to-end tests are already in place. They've been refactored since they referred to localStorage changes.