Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where we cant resolve custom types #6016

Merged
merged 2 commits into from Mar 18, 2024
Merged

Conversation

sgulseth
Copy link
Member

Description

Found a bug where we some times can't extract a schemaType, turns out we were resolving the wrong schema type.

Types defined like this doesn't work:

defineType({
  name: 'customStringType',
  title: 'My custom string type',
  type: 'string',
}),

What to review

Correctnes

Testing

Added 👍

Notes for release

N/A - no notes needed

@sgulseth sgulseth requested a review from a team as a code owner March 15, 2024 18:17
@sgulseth sgulseth requested review from juice49 and removed request for a team March 15, 2024 18:17
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 18, 2024 9:37am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 9:37am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 9:37am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Component Testing Report Updated Mar 18, 2024 9:42 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 5s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

Copy link
Contributor

@ricokahler ricokahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It's actually very common for us to forget about the type chain too 😅 but I think this will do the trick! 👏

@sgulseth
Copy link
Member Author

sgulseth commented Mar 18, 2024

Types inside types inside types is confusing to reason about 😅 rebasing...

@sgulseth sgulseth added this pull request to the merge queue Mar 18, 2024
Merged via the queue into next with commit 217a47d Mar 18, 2024
36 checks passed
@sgulseth sgulseth deleted the fix/schema-extraction-bugs branch March 18, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants