fix: move typegen cli into @sanity/cli #6111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
No changes to documentation |
|
Component Testing Report Updated Mar 21, 2024 5:44 PM (UTC)
|
sgulseth
force-pushed
the
03-21-fix_move_typegen_cli_into_sanity_cli
branch
from
b5186e2
to
2c73f8a
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
sgulseth
force-pushed
the
03-21-fix_move_typegen_cli_into_sanity_cli
branch
from
2c73f8a
to
21fa739
Compare
bjoerge
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a command is applied to the
packages/sanitypackage it's only available under a "studio context". Typegen however does not require this as it has it own config, and reads "schema.json".Not sure why the linting fails here, I haven't touch was seems to be the relevant files?
What to review
Did I move all the pieces? 🙃
Testing
Added ✅
Notes for release
n/a - no notes needed