feat(sanity): use actions API when deleting documents #6115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Apr 8, 2024 1:20 PM (UTC)
|
Note: still work in progress, pending backend support for `skipCrossDatasetReferenceValidation`
bjoerge
force-pushed
the
feat/sdx-1163/delete-api
branch
from
c5d4173
to
7a8e0be
Compare
cngonzalez
reviewed
Apr 8, 2024
|
|
||
| if (isLiveEditEnabled(schema, typeName)) { |
There was a problem hiding this comment.
I notice that the delete action includes the drafts.live-edited-document-id when we execute a delete on a live-edited document.
The backend doesn't seem particularly bothered by this -- it includes a "mutations" array in its response payload that has just the live edited document ID, but is it something we should avoid sending?
There was a problem hiding this comment.
Good catch! I think it doesn't matter that much, and might even be preferable.
There's actually also a slight benefit - if you go from "liveEdit: false" to "liveEdit: true" while having a draft, the existing draft will still be floating around, which can cause trouble later on. Now that delete will also include deleting the draft, there's now actually a workaround (although veeery sketchy) in that you can hit delete on the document and then restore it later on.
There was a problem hiding this comment.
interesting, TIL! also interesting to consider as this API develops and we use it for other purposes.
with that in mind, IMO this is good to go :)
cngonzalez
approved these changes
Apr 8, 2024
juice49
pushed a commit
that referenced
this pull request
Apr 8, 2024
* feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action
juice49
pushed a commit
that referenced
this pull request
Apr 8, 2024
* feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action
juice49
pushed a commit
that referenced
this pull request
Apr 9, 2024
* feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action
juice49
pushed a commit
that referenced
this pull request
Apr 9, 2024
* feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action
juice49
pushed a commit
that referenced
this pull request
Apr 9, 2024
* feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action
juice49
pushed a commit
that referenced
this pull request
Apr 9, 2024
* feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action
bjoerge
added a commit
that referenced
this pull request
Apr 9, 2024
* feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action
bjoerge
added a commit
that referenced
this pull request
Apr 9, 2024
* feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
* test(structure): add document title test id * test(structure): document panel displays correct title for published document * feat(sanity): use actions API when publishing documents * feat(sanity): use Actions API when unpublishing documents (#6094) * feat(sanity): use Actions API when unpublishing documents * feat(core): set `skipCrossDatasetReferenceValidation` parameter when unpublishing documents * feat(sanity): use actions API when deleting documents (#6115) * feat(sanity): use actions API when deleting documents * fix(sanity): add skipCrossDatasetReferenceValidation to delete action --------- Co-authored-by: Bjørge Næss <bjoerge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be good to go now