[lang] Fixing the invalid detection of pure status for operations and…

… provides an API for retreiving the side-effect expressions.

Signed-off-by: Stéphane Galland <galland@arakhne.org>

main/coreplugins/io.sarl.lang/src/io/sarl/lang/typesystem/IOperationHelper.java

@@ -80,9 +80,23 @@ public interface IOperationHelper {
 	 * @param calledOperation the called operation. It is used for detecting recursive calls.
 	 * @param expr the expression to test, usually, the body of the expression.
 	 * @return <code>true</code> if a side effect was detected into the expression.
+	 * @see #getSideEffectCalls(InferredPrototype, XExpression)
 	 */
 	boolean hasSideEffects(InferredPrototype calledOperation, XExpression expr);
 
+	/** Replies the list of calls that have side effects into the given expression.
+	 *
+	 * <p>This function differs from {@link XExpressionHelper#hasSideEffects(XExpression)} because it explore the
+	 * syntax tree for determining if one action has a side effect.
+	 *
+	 * @param calledOperation the called operation. It is used for detecting recursive calls.
+	 * @param expr the expression to test, usually, the body of the expression.
+	 * @return the list of side-effect calls.
+	 * @since 0.12
+	 * @see #hasSideEffects(InferredPrototype, XExpression)
+	 */
+	Iterable<XExpression> getSideEffectExpressions(InferredPrototype calledOperation, XExpression expr);
+
 	/** Replies if the given operation could be annotated with {@code @Pure} according
 	 * to its associated adapters.
 	 *

main/coreplugins/io.sarl.lang/src/io/sarl/lang/typesystem/ISideEffectContext.java

@@ -26,6 +26,7 @@
 
 import org.eclipse.xtext.xbase.XExpression;
 import org.eclipse.xtext.xbase.lib.Inline;
+import org.eclipse.xtext.xbase.lib.Pure;
 
 import io.sarl.lang.sarl.actionprototype.InferredPrototype;
 
@@ -110,4 +111,27 @@ default ISideEffectContext branch() {
 	 */
 	List<? extends XExpression> getVariableValues(String name);
 
+	/** Replies if the side-effect exploration should stop at the first discovered side effect.
+	 *
+	 * @return {@code true} if the algorithm stops at first side-effect occurrence.
+	 * @since 0.12
+	 */
+	@Pure
+	boolean isStoppingAtFirstSideEffect();
+
+	/** Register the given call to have a side effect.
+	 *
+	 * @param expression the side-effect expression.
+	 * @since 0.12
+	 */
+	void registerSideEffect(XExpression expression);
+
+	/** Replies the detected side effect expressions.
+	 *
+	 * @return the side-effect expressions.
+	 * @since 0.12
+	 */
+	@Pure
+	Iterable<XExpression> getSideEffectExpressions();
+
 }