feat: Node 20 support (#3355)

* feat: Node 20 support * ci: update stalled Alpine/Linux jobs * feat: drop Node 14
sass · May 20, 2023 · 87f3899 · 87f3899
1 parent 06ae4c7
commit 87f3899
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 23 deletions.
diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml
@@ -15,11 +15,10 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 14
-          # Node 16+ are perma-red for the tests right now
-          # - 16
-          # - 18
-          # - 19
+          - 16
+          - 18
+          - 19
+          - 20
 
     steps:
       - name: Install Alpine build tools

diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -13,20 +13,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node:
-          - 14
-          - 16
-          - 18
-
         include:
-          - node: 14
-            gcc: "gcc-6"
-            gpp: "g++-6"
-            os: ubuntu-18.04
           - node: 16
             gcc: "gcc-8"
             gpp: "g++-8"
-            os: ubuntu-18.04
+            os: ubuntu-20.04
           - node: 18
             gcc: "gcc-8"
             gpp: "g++-8"
@@ -35,6 +26,10 @@ jobs:
             gcc: "gcc-8"
             gpp: "g++-8"
             os: ubuntu-20.04
+          - node: 20
+            gcc: "gcc-10"
+            gpp: "g++-10"
+            os: ubuntu-22.04
 
 
     steps:

diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -14,10 +14,10 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 14
           - 16
           - 18
           - 19
+          - 20
 
     steps:
       - uses: actions/checkout@v3

diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -14,10 +14,10 @@ jobs:
       fail-fast: false
       matrix:
         node:
-          - 14
           - 16
           - 18
           - 19
+          - 20
 
         architecture:
           - x64

diff --git a/README.md b/README.md
@@ -17,12 +17,13 @@ Below is a quick guide for minimum and maximum supported versions of node-sass:
 
 NodeJS  | Supported node-sass version | Node Module
 --------|-----------------------------|------------
+Node 20 | 9.0+                        | 115
 Node 19 | 8.0+                        | 111
 Node 18 | 8.0+                        | 108
 Node 17 | 7.0+, <8.0                  | 102
 Node 16 | 6.0+                        | 93
 Node 15 | 5.0+, <7.0                  | 88
-Node 14 | 4.14+                       | 83
+Node 14 | 4.14+, <9.0                 | 83
 Node 13 | 4.13+, <5.0                 | 79
 Node 12 | 4.12+, <8.0                 | 72
 Node 11 | 4.10+, <5.0                 | 67

diff --git a/appveyor.yml b/appveyor.yml
@@ -33,9 +33,6 @@
   environment:
     SKIP_SASS_BINARY_DOWNLOAD_FOR_CI: true
     matrix:
-      - nodejs_version: 14
-        GYP_MSVS_VERSION: 2017
-        APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
       - nodejs_version: 16
         GYP_MSVS_VERSION: 2019
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
@@ -45,6 +42,9 @@
       - nodejs_version: 19
         GYP_MSVS_VERSION: 2019
         APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
+      - nodejs_version: 20
+        GYP_MSVS_VERSION: 2019
+        APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
 
 
   install:

diff --git a/lib/extensions.js b/lib/extensions.js
@@ -84,6 +84,7 @@ function getHumanNodeVersion(abi) {
     case 102: return 'Node.js 17.x';
     case 108: return 'Node.js 18.x';
     case 111: return 'Node.js 19.x';
+    case 115: return 'Node.js 20.x';
     default: return false;
   }
 }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "node-sass",
-  "version": "8.0.0",
+  "version": "9.0.0",
   "libsass": "3.5.5",
   "description": "Wrapper around libsass",
   "license": "MIT",
@@ -16,7 +16,7 @@
     "url": "http://andrew.github.com"
   },
   "engines": {
-    "node": ">=14"
+    "node": ">=16"
   },
   "main": "lib/index.js",
   "nodeSassConfig": {