Refactor @content arguments specs
#1543
Conversation
jathak
changed the title
@content arguments specs
| <===> | ||
| ================================================================================ | ||
| <===> syntax/arglist/invalid/input.scss | ||
| @mixin mixin { |
There was a problem hiding this comment.
| @mixin mixin { | |
| @mixin a { |
Super nitty, but these specs were written before the style guide was locked in, so they don't follow DO use single-letter names for irrelevant placeholders. Since you're touching them anyway, it's probably worth updating them to fully follow the style guide.
| <===> no_parens/no_using/input.scss | ||
| @mixin mixin { | ||
| @content; | ||
| } | ||
|
|
||
| a { | ||
| @include mixin { | ||
| x: y; | ||
| } | ||
| } | ||
|
|
||
| <===> no_parens/no_using/output.css | ||
| a { | ||
| x: y; | ||
| } |
There was a problem hiding this comment.
It seems strange to have a spec under content/arguments that calls a mixin without passing any arguments to its content block.
| <===> with_defaults/nothing_passed/input.scss | ||
| @mixin mixin { | ||
| @content; | ||
| } | ||
|
|
||
| a { | ||
| @include mixin using ($arg1: value1, $arg2: value2) { | ||
| arg1: $arg1; | ||
| arg2: $arg2; | ||
| } | ||
| } |
There was a problem hiding this comment.
This seems redundant with the default_using specs in none.hrx.
| <===> with_splat/both_passed/input.scss | ||
| @mixin mixin { | ||
| @content(value1, $arg2: value2); | ||
| } | ||
|
|
||
| a { | ||
| @include mixin using ($args...) { | ||
| positional: inspect($args); | ||
| keywords: inspect(keywords($args)); | ||
| } | ||
| } | ||
|
|
||
| <===> with_splat/both_passed/output.css | ||
| a { | ||
| positional: (value1,); | ||
| keywords: (arg2: value2); | ||
| } | ||
|
|
||
| <===> with_splat/both_passed/output-libsass.css | ||
| a { | ||
| positional: value1; | ||
| keywords: (arg2: value2); | ||
| } |
There was a problem hiding this comment.
It's probably also a good idea to add a spec covering passing an ArgumentList object that contains both keywords and positional args to a @content.
| <===> | ||
| ================================================================================ | ||
| <===> no_argument/input.scss | ||
| $var: top-level; | ||
|
|
||
| @mixin mixin($var) { | ||
| mixin-var-before: $var; | ||
| @content; | ||
| mixin-var-after: $var; | ||
| } | ||
|
|
||
| a { | ||
| @include mixin(mixin-argument) { | ||
| content-var: $var; | ||
| } | ||
| } | ||
|
|
||
| <===> no_argument/output.css | ||
| a { | ||
| mixin-var-before: mixin-argument; | ||
| content-var: top-level; | ||
| mixin-var-after: mixin-argument; | ||
| } |
There was a problem hiding this comment.
As above, since this isn't actually declaring or passing content arguments, it seems like it doesn't belong here.
|
Hello, I've come across an interesting case when compiling Bootstrap that may be relevant here. The minimized version is @mixin foo($arg) {
@include bar {
color: $arg;
}
}
@mixin bar {
@include baz {
@content;
}
}
@mixin baz {
@content;
}
@mixin font-size($value) {
@include foo($value);
}
a {
@include font-size(1rem);
}which I suppose can be thought of as a triple chain of |
No description provided.