Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SI-7149 Use a WeakHashSet for type uniqueness #2605

Merged
merged 3 commits into from Jun 4, 2013
Merged

SI-7149 Use a WeakHashSet for type uniqueness #2605

merged 3 commits into from Jun 4, 2013

Commits on Jun 4, 2013

  1. SI-7150 Replace scala.reflect.internal.WeakHashSet 

    Replaces scala.reflect.internal.WeakHashSet with a version that
* extends the mutable.Set trait
* doesn't leak WeakReferences
* is unit tested
    James Iry committed Jun 4, 2013
    Configuration menu
    Copy the full SHA
    ad63f36 View commit details
    Browse the repository at this point in the history

  2. SI-7149 Use a WeakHashSet for type uniqueness 

    Currently type uniqueness is done via a HashSet[Type], but
that means the Types live through an entire compile session, even
ones that are used once. The result is a huge amount of unnecessarily
retained memory. This commit uses a WeakHashSet instead so that Types
and their WeakReferences are cleaned up when no longer in use.
    James Iry committed Jun 4, 2013
    Configuration menu
    Copy the full SHA
    746d85b View commit details
    Browse the repository at this point in the history

  3. Modify perRunCaches to not leak WeakReferences 

    perRunCaches was using a HashMap of WeakReferences which meant it would
accumulate WeakReferences over time. This commit uses a WeakHashSet
instead so that the references are cleaned up.
    James Iry committed Jun 4, 2013
    Configuration menu
    Copy the full SHA
    b7e0fd2 View commit details
    Browse the repository at this point in the history