Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another grab bag of compiler optimizations #3449

Merged
merged 4 commits into from Feb 5, 2014
Merged

Another grab bag of compiler optimizations #3449

merged 4 commits into from Feb 5, 2014

Conversation

retronym
Copy link
Member

Review by @gkossakowski

@retronym
Optimize generic signatures utility method dotCleanup
e3af86a
@retronym
Avoid needless Name creation
811e423 
 - Don't create names just to perform prefix/suffix checks
 - Don't create names, decode, *and* intern strings in ICode
@retronym
Optimization in Uncurry
86bc324 
Only perform HashMap lookup of a tree until after checking more
cheaply if it refers to a symbol with by-name parameter type.
@retronym
Avoid work in GenICode#run when inactive.
a2f595c 
scalaPrimitives.init() represented 1% of a small (1s)
compilation run.
@retronym
Copy link
Member Author

retronym commented Feb 1, 2014

PLS REBUILD/pr-scala@e3af86a

[info] [info] ! Prop.within: Falsified after 73 passed tests.
[info] [info] > Labels of failing property: 
[info] [info] Timeout
[info] [info] > ARG_0: 100
[info] [info] > ARG_1: 10
[info] [info] + Prop.sizedProp: OK, passed 100 tests.
[info] [info] + Prop.someFailing: OK, passed 100 tests.

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 33866713)
🐱 Roger! Rebuilding pr-scala for e3af86a. 🚨

@ghost ghost assigned gkossakowski Feb 1, 2014
@gkossakowski
Copy link
Member

PLS REBUILD ALL

Somehow PR validator got stuck on this one.

@scala-jenkins
Copy link

(kitty-note-to-self: ignore 33907105)
🐱 Roger! Rebuilding pr-scala for e3af86a, 811e423, 86bc324, a2f595c. 🚨

@retronym
Copy link
Member Author

retronym commented Feb 5, 2014

Review by @gkossakowski, please

@gkossakowski
Copy link
Member

LGTM.

gkossakowski added a commit that referenced this pull request Feb 5, 2014
@gkossakowski
Merge pull request #3449 from retronym/topic/opt11
bd81f93 
Another grab bag of compiler optimizations
@gkossakowski gkossakowski merged commit bd81f93 into scala:master Feb 5, 2014
xuwei-k
xuwei-k reviewed Apr 24, 2014
View reviewed changes
src/compiler/scala/tools/nsc/transform/Erasure.scala
case '.' if last != '>' => last = '.' ; '$'
case ch => last = ch ; ch
var i = 0
val len = sig.length
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot, I guess I meant to use it in the while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gkossakowski gkossakowski

Labels
None yet
Projects
None yet
Milestone
2.11.0-RC1
6 participants
@retronym @scala-jenkins @gkossakowski @soc @som-snytt @xuwei-k