Spelling #2381

jsoref · 2022-07-28T22:57:17Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@ecfa03a#commitcomment-79693156

The action reports that the changes in this PR would make it happy: jsoref@f440cae

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref

Most changes were automatically suggested by Google Sheets. All fault mine.

jsoref · 2022-07-28T22:58:57Z

core/src/main/scala/scalaz/Apply.scala

  def compose[G[_]](implicit G0: Apply[G]): Apply[λ[α => F[G[α]]]] =
    new CompositionApply[F, G] {
      implicit def F = self
      implicit def G = G0
    }

-  /**The product of Applys `F` and `G`, `[x](F[x], G[x]])`, is a Apply */
+  /**The product of `Apply`s `F` and `G`, `[x](F[x], G[x]])`, is a Apply */


This seems to be a reasonable match to the use of Apply on line 60

jsoref · 2022-07-28T22:59:09Z

core/src/main/scala/scalaz/Day.scala

@@ -7,7 +7,7 @@ package scalaz
  *
  * Day convolution is a special form of Functor multiplication.
  * In monoidal category of endofunctors Applicative is a monoid object when Day covolution is used as tensor.
-  * If we use Functor composition as tensor then then monoid form a Monad instead of Applicative.
+  * If we use Functor composition as tensor then the monoid form a Monad instead of Applicative.


I'm not at all sure about this.

jsoref · 2022-07-28T22:59:57Z

core/src/main/scala/scalaz/Dequeue.scala

@@ -7,7 +7,7 @@ package scalaz
  * A queue that allows items to be put onto either the front (cons)
  * or the back (snoc) of the queue in constant time, and constant
  * time access to the element at the very front or the very back of
-  * the queue.  Dequeueing an element from either end is constant time
+  * the queue.  Dequeuing an element from either end is constant time


Happy to drop this or anything else.

jsoref · 2022-07-28T23:00:51Z

example/src/main/scala/scalaz/example/ContravariantCoyonedaUsage.scala

@@ -538,7 +538,7 @@ object ContravariantCoyonedaUsage {
      s.foldMap{case (st, i) => recItem[BinOrd](i, sortTypeBinOrd(st))}

    // The drawback here is that I can’t just build a separate stack
-    // willynilly for `Binfmt'.  I have to prove at each step that *the
+    // willy nilly for `Binfmt'.  I have to prove at each step that *the


Google Sheets made this (and most of the other corrections). I probably wouldn't have actively made it, but it's right.

jsoref · 2022-07-28T23:01:17Z

example/src/main/scala/scalaz/example/KleisliUsage.scala

@@ -25,7 +25,7 @@ object KleisliUsage {
      Continent("Asia",
        List(
          Country("India",
-            List(City("New Dehli"), City("Calcutta"))))))
+            List(City("New Delhi"), City("Calcutta"))))))


Proper name...

jsoref · 2022-07-28T23:01:27Z

example/src/main/scala/scalaz/example/ReaderWriterStateTUsage.scala

@@ -28,7 +28,7 @@ case object B extends Token

 object Token {

-  implicit val euqalsRef: Equal[Token] = Equal.equalRef
+  implicit val equalsRef: Equal[Token] = Equal.equalRef


jsoref · 2022-07-28T23:02:11Z

tests/src/test/scala/scalaz/DListTest.scala

@@ -38,7 +38,7 @@ object DListTest extends SpecLite {
    def monoid[A] = Monoid[DList[A]]
    def monadPlus = MonadPlus[DList]
    def alt = Alt[DList]
-    def bindrec = BindRec[DList]
+    def bindRec = BindRec[DList]


This change is the scariest (it occurs in three files).

I can't understand how this code could compile in both forms. Based on the surrounding code, this change appears to be correct, but 🤷 .

It's just an unused method to test whether BindRec[DList] compiles or not. So any name would be OK.

jsoref · 2022-07-28T23:02:19Z

tests/src/test/scala/scalaz/std/ListTest.scala

@@ -49,7 +49,7 @@ object ListTest extends SpecLite {
      a.groupWhenM[Id](p).map(_.list.toList).flatten must_===(a)
  }

-  "groupByWhenM[Id] ∀(i,j) | 0<i<resut.len & 0<j<result(i).len: p(result(i)(j), p(result(i)(j+1)) yields true" ! forAll {
+  "groupByWhenM[Id] ∀(i,j) | 0<i<result.len & 0<j<result(i).len: p(result(i)(j), p(result(i)(j+1)) yields true" ! forAll {


Atry

We should not rename public API. It would be nice to create a new method with the correct name and deprecate the old typo method.

Atry · 2023-02-03T07:43:18Z

core/src/main/scala/scalaz/Heap.scala

@@ -409,7 +409,7 @@ object Heap extends HeapInstances {
        ins(f, link(f)(t, tp))(ts)
    }

-    def uniqify[A](f: (A, A) => Boolean): Forest[A] => Forest[A] = {
+    def uniquify[A](f: (A, A) => Boolean): Forest[A] => Forest[A] = {


This is a public API. We should keep the original method for backward compatibility.

I've added a deprecated method with the original name that calls this method: https://github.com/scalaz/scalaz/compare/3b0bbbf7de95f0b02288c57aa839462f2deca9e3..561f47ff91cdcc603cf9ac048b831e88bf504730

Does that do what you're looking for?

Are there other methods that need this treatment?

Atry

Still contains public API changes

scalacheck-binding/src/main/scala/scalaz/scalacheck/ScalazArbitrary.scala

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Atry · 2023-02-10T02:59:52Z

Looks good to me.
@xuwei-k What do you think?

I am not sure if we could simply rename a public API without deprecation, considering the master branch does not promise backward compatibility.

spelling: apply

effa4d4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref requested a review from xuwei-k as a code owner July 28, 2022 22:57

jsoref commented Jul 28, 2022

View reviewed changes

Atry requested changes Feb 3, 2023

View reviewed changes

jsoref force-pushed the spelling branch from 3b0bbbf to 561f47f Compare February 5, 2023 05:59

Jamal985610 approved these changes Feb 9, 2023

View reviewed changes

jsoref requested review from Atry and removed request for xuwei-k February 9, 2023 21:56

Atry requested changes Feb 9, 2023

View reviewed changes

jsoref requested a review from Atry February 9, 2023 22:37

Atry reviewed Feb 10, 2023

View reviewed changes

scalacheck-binding/src/main/scala/scalaz/scalacheck/ScalazArbitrary.scala Outdated Show resolved Hide resolved

jsoref added 16 commits February 9, 2023 21:15

spelling: bindrec

d052b9b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: delhi

f2a5670

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: dequeuing

7bde543

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: equals

e99f1a0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: indices

f3f78dd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: indiscernibility

da5d0b0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: indiscernible

6ca7ca1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: injector

2fbb9f9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: language

1d8eced

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: morphisms

43505df

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: nondeterministic

c92a6d3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: nondeterministically

d1353bc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: result

81cfb11

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: the

ce7bf3c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: uniquify

7f209af

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: willy nilly

dc97fd9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from 561f47f to dc97fd9 Compare February 10, 2023 02:16

Atry approved these changes Feb 10, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #2381

Spelling #2381

jsoref commented Jul 28, 2022

jsoref left a comment

jsoref Jul 28, 2022

jsoref Jul 28, 2022

jsoref Jul 28, 2022

jsoref Jul 28, 2022

jsoref Jul 28, 2022

jsoref Jul 28, 2022

jsoref Jul 28, 2022

Atry Feb 10, 2023 •

edited

jsoref Jul 28, 2022

Atry left a comment

Atry Feb 3, 2023

jsoref Feb 9, 2023

Atry left a comment

Atry commented Feb 10, 2023 •

edited

Spelling #2381

Are you sure you want to change the base?

Spelling #2381

Conversation

jsoref commented Jul 28, 2022

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Atry Feb 10, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Atry left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Atry left a comment

Choose a reason for hiding this comment

Atry commented Feb 10, 2023 • edited

Atry Feb 10, 2023 •

edited

Atry commented Feb 10, 2023 •

edited