This repository has been archived by the owner on Nov 29, 2020. It is now read-only.
Fix some issues reported by LGTM #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM recommendation:
This parameter of type 2 Values is 72 bytes - consider passing a const pointer/reference instead.
The parameters pln2img and img2pln are too large to be efficiently passed by value.
In addition, the const qualifiers were missing in the header file.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
This fixes a hint from LGTM:
Functions should be declared at file scope, not inside blocks.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
LGTM warnings:
The 'const' modifier has no effect on return types.
The 'const' modifying the return type can be removed.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
LGTM warnings:
Comparison is always false because sf >= 0.
Comparison is always false because ef >= 0.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://lgtm.com/projects/g/scantailor/scantailor/alerts/.