Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove storage of events and results from History #198

Closed
schwern opened this issue Nov 14, 2011 · 1 comment
Closed

Remove storage of events and results from History #198

schwern opened this issue Nov 14, 2011 · 1 comment
Assignees
@schwern
Labels
DO IT Gardening History Test-Builder2
Milestone
Test::Builder1.5 ...

Comments

@schwern
Copy link
Contributor

schwern commented Nov 14, 2011

Ideally, TB2 should consume O(1) memory no matter how many results are run. This cannot be true if History stores events and results. To satisfy this, History keeps statistics and there is the TB2::NoHistory subclass which does not store events.

Unfortunately, when something is passed a "History" object, it might be NoHistory and thus some methods might not be safe to use. This is awkward. The relationship should be inverted. TB2::History should only keep statistics. A subclass or role or even separate watcher should store roles and events.

Change Test::Builder2::History to only store event statistics. Add whatever methods are necessary to make History useful to all its current users.

Write a role which stores events and results. Make sure there's a hook in History->accept_event to store the event if $self does the role.
@schwern schwern mentioned this issue Nov 29, 2011
Closed
schwern added a commit that referenced this issue Nov 29, 2011
@schwern
Remove TB2::NoHistory, it is unmaintained and has no future.
2e26035 
TB2::History will take over this role eventually (see #198).  Meanwhile, there's no
point in letting people rely on a half implementation that's going to be deleted.

For #241
@ghost ghost assigned schwern May 11, 2012
@schwern schwern mentioned this issue May 26, 2012
Closed
schwern added a commit that referenced this issue May 26, 2012
@schwern
Move event storage out of TB2::History and into a new TB2::History::E…
9626992 
…ventStorage object.

Then we can add an EventStorage that throws out events.

This was the last use of TB2::Stack and TB2::StackBuilder, so they're removed.

For #198
schwern added a commit that referenced this issue May 26, 2012
@schwern
Add TB2::History::NoEventStorage which TB2::History will use.
97d3d48 
For #198
schwern added a commit that referenced this issue May 26, 2012
@schwern
Make NoEventStorage inherit from EventStorage so isa(EventStorage) wo…
e98b44b 
…rks.

For #198
schwern added a commit that referenced this issue May 26, 2012
@schwern
Add an option to turn off event storage.
af577ec 
Also test that things work with event storage off.  Not terribly well tested right now.

For #198
schwern added a commit that referenced this issue May 26, 2012
@schwern
Move the History->consume tests into their own test.
e47df19 
They're a bit complicated.

For #198
schwern added a commit that referenced this issue May 26, 2012
@schwern
Make the errors from NoEventStorage bubble up through History.
adc2c55 
So the user sees their own call to TB2::History not inside TB2::History.

For #198
schwern added a commit that referenced this issue May 26, 2012
@schwern
Swith over to not storing test events.
b1aa706 
Things which are needed:
1) A way to turn on storage in
   use Test::More
   Test::Builder->create
2) Better docs about how to use (or not use) Test::Builder->results, events and
   Test::More summary and details.

For #198
schwern added a commit that referenced this issue May 26, 2012
@schwern
Remove the now redundant History->test_count
43a460e 
Synonym for result_count

For #198
schwern added a commit that referenced this issue May 26, 2012
@schwern
Consolodate the statistics in History
e98bf15 
* Move all the count attributes together
* Remove a now irrelevant comment

For #198
@schwern schwern mentioned this issue May 26, 2012
Merged
@schwern
Copy link
Contributor Author

schwern commented Jun 18, 2012

Complete. I decided to use a storage object rather than a role. Per-object roles might not make it after Mouse gets torn out and they might have performance issues.

@schwern schwern closed this as completed Apr 23, 2013
@schwernbot schwernbot mentioned this issue Mar 16, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schwern schwern

Labels
DO IT Gardening History Test-Builder2
Projects
None yet
Milestone
Test::Builder1.5 stable release
Development

No branches or pull requests
1 participant
@schwern