BUG: smirnov -- make comparison robust to handle NaNs #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
any comparison (< or >=) with NaN is False, so check to belong to the range [x,y] must be done with (>=x)&&(<=y) and not !((<x)||(>y)) This issue happens to be critical especially for big-endian architectures leading to stalling in smirnov due to excessive looping later in the code. References: http://bugs.debian.org/cgi-bin/bugreport.cgi\?bug\=653948 http://mail.scipy.org/pipermail/scipy-dev/2012-March/017298.html
|
Thanks, this looks correct. A small regression test should be added (e.g. during merge). |
|
Just to make clear -- a regression test was not expected from me, was it? ;-) |
|
@yarikoptic: Well, if you add it, someone else doesn't need to :) But if you don't, it shouldn't hold back merging this |
|
tested that it does halt with unpatched version and completes with patched one (not sure if that qualifies for a term "regression test" without comparing to smth :-P ;-) ) Thank you @stefanv ! |
|
It will catch the regression, at least :) @pv what do you think? |
|
Merged in f7083b6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any comparison (< or >=) with NaN is False, so check to belong to the range
[x,y] must be done with (>=x)&&(<=y) and not !((<x)||(>y))
This issue happens to be critical especially for big-endian architectures
leading to stalling in smirnov due to excessive looping later in the code.
References:
http://bugs.debian.org/cgi-bin/bugreport.cgi\?bug\=653948
http://mail.scipy.org/pipermail/scipy-dev/2012-March/017298.html