Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add t-test with unequal variances, bug fix for edge case on all tests #227

Closed
wants to merge 1 commit into from
Closed

Conversation

MrCreosote
Copy link
Contributor

Added method for t-test with unequal variances. ttest_ind assumes
population variances are equal.

Refactor common code in all 4 t-test methods to _ttest_ind_setup and
_ttest_finish.

Fix bug in all 4 methods. Previous implementation would, if the
difference in means and the denominator of the t-statistic were zero,
set the t-statistic equal to 1. If the difference in means is zero, the
t-statistic should always be zero. Code and respective tests changed to
reflect this.

Added method for t-test with unequal variances. ttest_ind assumes
population variances are equal.

Refactor common code in all 4 t-test methods to _ttest_ind_setup and
_ttest_finish.

Fix bug in all 4 methods. Previous implementation would, if the
difference in means and the denominator of the t-statistic were zero,
set the t-statistic equal to 1. If the difference in means is zero, the
t-statistic should always be zero. Code and respective tests changed to
reflect this.
@MrCreosote
Copy link
Contributor Author

Gmane discussion here.

@MrCreosote MrCreosote closed this Jun 3, 2012
@pv
Copy link
Member

pv commented Jun 3, 2012

Note that you can git push -f to the same branch, if you need to rebase/amend a commit --- no need to open a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants