Objects returned from MemoryStore cache should not be frozen, they sh…

…ould be duplicates. This makes Rails.cache.read behave the same for MemoryStore as it does for MemCacheStore.
scottwb · Aug 7, 2010 · 46f73da · 46f73da
1 parent bdbf727
commit 46f73da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/activesupport/lib/active_support/cache/memory_store.rb b/activesupport/lib/active_support/cache/memory_store.rb
@@ -27,7 +27,7 @@ def read_multi(*names)
 
       def read(name, options = nil)
         super
-        @data[name]
+        @data[name].duplicable? ? @data[name].dup : @data[name]
       end
 
       def write(name, value, options = nil)

diff --git a/activesupport/test/caching_test.rb b/activesupport/test/caching_test.rb
@@ -165,7 +165,7 @@ def setup
 
   def test_store_objects_should_be_immutable
     @cache.write('foo', 'bar')
-    assert_raise(ActiveSupport::FrozenObjectError) { @cache.read('foo').gsub!(/.*/, 'baz') }
+    @cache.read('foo').gsub!(/.*/, 'baz')
     assert_equal 'bar', @cache.read('foo')
   end