Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the Wayland greeter default to use Weston's Kiosk shell #1860

Merged
merged 1 commit into from Feb 22, 2024

Conversation

Conan-Kudo
Copy link
Contributor

Weston introduced the kiosk shell in Weston 9.0 and deprecated the fullscreen shell in Weston 12.0.

@Conan-Kudo
Copy link
Contributor Author

I've marked this as draft because I don't know how we want to handle this. My understanding is that this functionality does not work properly in Qt 5 without the KDE patch set. If we're fine with assuming that it will be built against and run with Qt 5 only with the KDE Patch Collection applied, then we can land this now. Otherwise we have to wait until we strip out Qt 5 support and go Qt 6-only.

cc: @fooishbar, @davidedmundson

@Vogtinator
Copy link
Contributor

I've marked this as draft because I don't know how we want to handle this. My understanding is that this functionality does not work properly in Qt 5 without the KDE patch set.

In which way?

@Conan-Kudo
Copy link
Contributor Author

I don't remember exactly where I read it, but apparently xdg-toplevel on xdg-shell doesn't work properly with QtWayland without the KDE Patch Collection?

@Conan-Kudo
Copy link
Contributor Author

Ah, here's where I saw it. It was a comment by @davidedmundson here: #1393 (comment)

@Vogtinator
Copy link
Contributor

Vogtinator commented Jan 30, 2024

Ok. IMO checking the Qt version during buildtime is close enough, let's just assume that any distro with Qt >= 5.15.10 uses the patch collection?

@Conan-Kudo
Copy link
Contributor Author

Yeah, I would say so.

@fooishbar
Copy link

Yeah the Weston patch is great, thanks.

@Conan-Kudo Conan-Kudo marked this pull request as ready for review February 14, 2024 10:21
Weston introduced the kiosk shell in Weston 9.0 and deprecated the
fullscreen shell in Weston 12.0.
@Conan-Kudo
Copy link
Contributor Author

Conan-Kudo commented Feb 22, 2024

@Vogtinator can we land this, please? Weston is working to remove fullscreen shell, and this is the only user of it I can find in Fedora.

@Vogtinator Vogtinator merged commit dfc3bdb into sddm:develop Feb 22, 2024
12 of 13 checks passed
@Conan-Kudo Conan-Kudo deleted the sddm-weston-kiosk branch February 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants