New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the Wayland greeter default to use Weston's Kiosk shell #1860
Conversation
I've marked this as draft because I don't know how we want to handle this. My understanding is that this functionality does not work properly in Qt 5 without the KDE patch set. If we're fine with assuming that it will be built against and run with Qt 5 only with the KDE Patch Collection applied, then we can land this now. Otherwise we have to wait until we strip out Qt 5 support and go Qt 6-only. |
In which way? |
I don't remember exactly where I read it, but apparently xdg-toplevel on xdg-shell doesn't work properly with QtWayland without the KDE Patch Collection? |
Ah, here's where I saw it. It was a comment by @davidedmundson here: #1393 (comment) |
Ok. IMO checking the Qt version during buildtime is close enough, let's just assume that any distro with Qt >= 5.15.10 uses the patch collection? |
Yeah, I would say so. |
Yeah the Weston patch is great, thanks. |
Weston introduced the kiosk shell in Weston 9.0 and deprecated the fullscreen shell in Weston 12.0.
6fd2279
to
afe016c
Compare
@Vogtinator can we land this, please? Weston is working to remove fullscreen shell, and this is the only user of it I can find in Fedora. |
Weston introduced the kiosk shell in Weston 9.0 and deprecated the fullscreen shell in Weston 12.0.