fixup: Fix #595 #693
Open
fixup: Fix #595 #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the failing CI test has to do with the fact that the flake8 module that you're using seems to not like the import aliasing that needs to be used to fix the issue addressed by this PR and that exports the For reference, I'm using the type checker rules listed on the pyright README here, but, to my understanding these are rules common to more type checkers for Python. |
navmed
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #595, by re-exporting
parse().parse()should be re-exported so that the user can just callpendulum.parse()as documented, given that the module is marked withpy.typed.No tests have been modified or added for this bugfix.