Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination and sorting mechanism #185

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Add pagination and sorting mechanism #185

wants to merge 10 commits into from

Conversation

sosna
Copy link
Member

@sosna sosna commented Dec 15, 2023

Fix #50
Fix #151

agent96
agent96 previously approved these changes Dec 15, 2023
Sort:  
- by default, always group observations into time series and sort by ascending time period
- within components sort by code ID or non-coded value

Pagination:
- added series key for serieskeyonly queries
- shorten sentence (and correct missing word)
Sort:  
- by default, always group observations into time series and sort by ascending time period
- within components sort by code ID or non-coded value

Pagination:  
- added series key for serieskeyonly queries
Pagination:
- added series key for serieskeyonly queries

Corrections for `e.g.` syntax.
@dosse
Copy link
Contributor

dosse commented Dec 16, 2023

@sosna I made the following changes:

Rest-cheat-sheet:

  • syntax corrections for e.g.

Pagination:

  • added series key for serieskeyonly queries

Sort:

  • by default, always group observations into time series and sort by ascending time period
  • within components sort by code ID or non-coded value

Something that still needs clarification is the following:

If the data are sorted by the components in the order stated in the sort clause, then sort=TIME_PERIOD:desc would do the following: It would first sort in descending order of TIME_PERIOD and then by the other components in a nondeterministic way, e.g.,

  FREQ,DIM1,TIME_PERIOD,OBS_VALUE
  A,A,2022,1.0654
  A,B,2022,1.0261
  A,A,2021,1.0752
  A,B,2021,1.0730

In consequence, the observations will not be grouped by time series. I don't think that this was intended with sort=TIME_PERIOD:desc, right?

This could be solved by saying:
The data are sorted first in a nondeterministic way for any component not included in the sort parameter and then in the order of components in the sort parameter. In this way, sort=TIME_PERIOD:asc would also be the default sorting value if the data has a time dimension.

Ok for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ordering the data query results by dimensions Allow slicing of data messages
4 participants