Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic grappelli dashboard size based on columns from Dashboard class #808

Open
wants to merge 1 commit into
base: stable/2.7.x
Choose a base branch
from

Conversation

orlra
Copy link

@orlra orlra commented May 4, 2017

Columns variable was ignored in template. While columns==2 my Django grappelli showed 3 columns and I wanted to make it 4.
My solution works with 1,2,3,4,5 columns, any more and longer names will pop up out of boxes.
columns use use 23 as bs size as 24 is rounded up to 25 in widthratio template tag.

@orlra
Copy link
Author

orlra commented May 4, 2017

its single file override so you should be able to merge it to all dev branches.

@sehmaschine
Copy link
Owner

sehmaschine commented May 4, 2017

@orlra Did you target branch dev/2.7.x by purpose? Because it´s pretty outdated — the development branch for the current version is stable/2.9.x.

@orlra
Copy link
Author

orlra commented May 4, 2017

Ok I see what you meant. I should push it to stable 2.7.x instead ? I just thought dev branch was a test before things go to stable.
My project jumps between LTS versions and I need this in 1.8 Django. Thats why I targeted this branch. you should be able to cherry pick it up to all devs branches because from 2.7 nothing changed in this file.

@orlra orlra changed the base branch from dev/2.7.x to stable/2.7.x May 5, 2017 08:58
@orlra orlra changed the title Dynamic grapelli dashboard size based on columns from Dashboard class Dynamic grappelli dashboard size based on columns from Dashboard class May 5, 2017
@orlra
Copy link
Author

orlra commented May 5, 2017

If you with we can merge it to any other branch, But I would like to see it on stable/2.7.x if possible.

@sehmaschine
Copy link
Owner

@parsch please take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants