Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of erroring with no audio server, restore server-side --disable_audio CLI option or automatically detect no PulseAudio server #147

Open
ehfd opened this issue May 7, 2024 · 0 comments
Labels
enhancement New feature or request interface OS input, display, or audio interfaces transport Underlying media or data transport protocols web Web components including gst-web

Comments

@ehfd
Copy link
Member

ehfd commented May 7, 2024

Before v1.5.x, before #96, there was an option to disable audio both from the client and server.

This was needed because that was a time when we did not figure out the root cause of latency which arose from #7.

Even now, it isn't necessary to restore the client-side disable audio button since all web browsers now have the option to mute from the tab, but disabling server-side audio still does make sense.

This is because without an active PulseAudio/PipeWire-Pulse server, the whole connection crashes. Thus, this option is required to run Selkies without PulseAudio.

It would be even better to detect when pulsesrc is None instead of having the --disable_audio option and simply not to initialize the audio WebRTC stack if so instead of crashing.

Not immediately necessary within containers but the need may eventually arise in specialized environments such as bare metal or clusters.

This would involve restoring the code in #96 to be fit for the current state if going the first way, and handling pulsesrc is None gracefully in gstwebrtc_app.py if going the second way. I prefer the second way but the first way also works.

@ehfd ehfd added enhancement New feature or request transport Underlying media or data transport protocols web Web components including gst-web interface OS input, display, or audio interfaces labels May 7, 2024
@ehfd ehfd changed the title Restore server-side --disable_audio CLI option or automatically detect no PulseAudio server Instead of erroring with no audio server, restore server-side --disable_audio CLI option or automatically detect no PulseAudio server May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request interface OS input, display, or audio interfaces transport Underlying media or data transport protocols web Web components including gst-web
Projects
None yet
Development

No branches or pull requests

1 participant