Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video and audio in separate webrtcbins #96

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

danisla
Copy link
Member

@danisla danisla commented Sep 22, 2023

Fixes #7

  • Reduces latency when streaming with audio enabled.
  • AV sync is within reason.
  • Client connects separate RTCPeerConnections for audio and video.
  • Connections use the same config and STUN/TURN servers.
  • Backend signal clients and pipelines are also duplicated.
  • Removed option to disable audio from client and cli args.

Testing

You can test it with the example docker container like this:

Ubuntu 22.04

docker run --pull=always --name selkies -it --rm -p 8080:8080 -p 3478:3478 ghcr.io/selkies-project/selkies-gstreamer/gst-py-example:testing-ubuntu22.04

For Ubuntu 20.04:

docker run --pull=always --name selkies -it --rm -p 8080:8080 -p 3478:3478 ghcr.io/selkies-project/selkies-gstreamer/gst-py-example:testing-ubuntu20.04

- Reduces latency when streaming with audio enabled.
- AV sync is within reason.
- Client connects separate RTCPeerConnections for audio and video.
- Connections use the same config and STUN/TURN servers.
- Backend signal clients and pipelines are also duplicated.
- Removed option to disable audio from client and cli args.
@ehfd
Copy link
Member

ehfd commented Sep 23, 2023

I am no longer making approvements in the meantime because I don't think I can test these in my limited time.

Let's just merge quickly and sort out the issues later.

@danisla danisla merged commit a26d5a8 into main Sep 23, 2023
12 checks passed
@danisla danisla deleted the danisla/separate-av-streams branch September 23, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High latency when audio is enabled.
2 participants